Remove side-by-side translation view - #4479
Open
lunars97 wants to merge 5 commits into
Open
Conversation
lunars97
force-pushed
the
4351-remove-side-by-side-view
branch
2 times, most recently
from
August 4, 2026 07:27
338fd9a to
7b2033a
Compare
MizukiTemma
self-requested a review
August 7, 2026 15:17
MizukiTemma
approved these changes
Aug 7, 2026
MizukiTemma
left a comment
MizukiTemma
left a comment
Member
There was a problem hiding this comment.
Thank you, looks good 😸
Only a trivial suggestion for release note 🙈
MizukiTemma
force-pushed
the
4351-remove-side-by-side-view
branch
from
August 7, 2026 15:31
7b2033a to
9578e40
Compare
MizukiTemma
requested changes
Aug 7, 2026
MizukiTemma
left a comment
MizukiTemma
left a comment
Member
There was a problem hiding this comment.
Sorry for reverting the approval 🙇
The failing translation check seems to be not trivial 👀
You probably have to remove integreat_cms/cms/templates/pages/page_sbs.html and integreat_cms/cms/templates/imprint/imprint_sbs.html too. They are probably not rendered anymore anywhere.
lunars97
force-pushed
the
4351-remove-side-by-side-view
branch
from
August 9, 2026 15:35
bf0a6db to
330b75a
Compare
lunars97
force-pushed
the
4351-remove-side-by-side-view
branch
from
August 9, 2026 16:00
9204423 to
72ed13d
Compare
Contributor
Author
|
I am not sure about the failing tests 🤔 @MizukiTemma am i missing something? 🙈 |
Member
#4441 will ifx it. Assumed that, the PR was approved. |
bahaaTuffaha
approved these changes
Aug 12, 2026
bahaaTuffaha
left a comment
bahaaTuffaha
left a comment
Contributor
There was a problem hiding this comment.
LGTM ✅
- side-by-side page removed ✅
- It doesn't exist at imprint anymore ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This PR removes side-by-side translation view and all the logic related to it (e.g templates, views, translations)
Proposed changes
Side effects
Faithfulness to issue description and design
There are no intended deviations from the issue and design.
How to test
Resolved issues
Fixes: #4351
Pull Request Review Guidelines