Shortcodes in TinyMCE - #4292
Draft
PeterNerlich wants to merge 26 commits into
Draft
Conversation
…pdate ts + node?)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until this feature is ready to be released, any work on it is to be done in / merged into
feature/shortcodes-tinymceThe decision has been made to test shortcodes itself without special handling in javascript, by delivering the rendered HTML to TinyMCE and detecting any internal links in submitted content and substituting them with the equivalent shortcode. This PR exists only for reference / in case this is picked up again later, after Shortcodes themselves have proved valuable.
Short description
This Draft PR captures the early state of development on making Shortcodes accessible in the TinyMCE editor. As I expect that this will accumulate a lot of discussion over the next sprints, the actual merge into
developwill likely be done by a separate PR once the feature is complete and polished.feature/shortcodes-tinymceis intended as a long living feature branch, with additions and bugfixes being merged into it instead of usingdevelopto incrementally improve the feature. Some bugs and loose ends are already known, many more are expected.Before that still, the commit history is subject to major cleanup operations.
Proposed changes
TODO
contactshortcodeKnown bugs
<div>s in nested<div>s in nested<div>s in…") but sometimes areSide effects
Faithfulness to issue description and design
There was no design, the architecture was developed as-you-go. Visual UI is mostly aimed to be kept indistinguishable.
How to test
Resolved issues
Fixes: #4289
Pull Request Review Guidelines