4064: Announce dynamic content updates - #4285
Conversation
dfef2d3 to
d21356e
Compare
9924261 to
228cd79
Compare
89dc4e1 to
6dc28b8
Compare
| ` | ||
| const SpaceForTts = styled.View<{ $ttsPlayerVisible: boolean }>` | ||
| height: ${props => (props.$ttsPlayerVisible ? dimensions.ttsPlayerHeight : 0)}px; | ||
| height: ${props => (props.$ttsPlayerVisible ? dimensions.ttsPlayerHeight + dimensions.bottomNavigationHeight : 0)}px; |
There was a problem hiding this comment.
Thanks for catching it 🙈
There was a problem hiding this comment.
hmm I dont have any solution for this, except for removing additional height and leaving it to cover the last update date 🤔
There was a problem hiding this comment.
sorry I think the issue is not from here its from the BottomTabNavigator.tsx
sceneStyle: bottomTabsVisible
? undefined
: { paddingBottom: insets.bottom + dimensions.bottomNavigationHeight },There was a problem hiding this comment.
yes, I mean this. I added it to add a height to not cover the last update date, but then it breaks the whole view when there are no navigation tabs...
There was a problem hiding this comment.
I can think of 2 possible solutions for the spacing at aschaffenburg:
- at TtsPlayer.tsx
insetBottom={bottom + (bottomTabsVisible ? dimensions.bottomNavigationHeight : 0)}now the difficulty is where can we get the bottomTabsVisible:
const { regionCode } = useAppContext()
const { data: regions } = useLoadRegions()
const region = regions?.find(it => it.code === regionCode)
const bottomTabsVisible = !!(
region?.placesEnabled ||
region?.localNewsEnabled ||
region?.tuNewsEnabled ||
region?.eventsEnabled
)- Or create a custom hook for bottom tab navigation visibility that has a context.
- OR maybe
buildConfig().featureFlags.fixedRegionbut a fixed region could have a bottom nav right?
There was a problem hiding this comment.
I will try this out, thank you 💚
There was a problem hiding this comment.
I guess the 3rd option is the simplest and robust :)
There was a problem hiding this comment.
Unless they add a tab 👀 ... so it needs a comment just incase.
There was a problem hiding this comment.
hmm i have't thougth about, good point 👍
0e56dc6 to
3dd37e4
Compare
3dd37e4 to
69e2df7
Compare


Short Description
This PR implements announcement for dynamic content which is either updated automatically or in response to a user action, to make sure that users are notified of this update in an accessible way.
Proposed Changes
FABto fix the chat fab button not being recognized by screen-reader also relates to Accessibility issues with screen reader #4223Side Effects
Uses react-native Pressable instead of react-native-paper FAB for Chat Button
Checklist
Testing
Resolved Issues
Fixes: #4064 #4297
Parially fixes #4223