Skip to content

fix(shutdown): stabilize drain teardown#1487

Merged
corylanou merged 3 commits into
mainfrom
detent/detent-digitaldrywood_detent_1484-7f26a6810dec
Jul 22, 2026
Merged

fix(shutdown): stabilize drain teardown#1487
corylanou merged 3 commits into
mainfrom
detent/detent-digitaldrywood_detent_1484-7f26a6810dec

Conversation

@corylanou

Copy link
Copy Markdown
Contributor

Summary

  • publish and latch draining telemetry before potentially blocked orchestrator work
  • keep health and state endpoints responsive during drain without store or project enrichment
  • preserve forced and timed-out shutdown results over cancellation cleanup noise while reaping owned worker groups under one deadline
  • route second signal and TUI interrupts through the shutdown state machine with a bounded OS fallback

Fixes #1484

UI Surface Contract

  • N/A; this change does not alter a high-impact UI surface, layout, density, first viewport, or responsive visibility.
  • This PR does not add persistent top-of-screen messaging.
  • No visual changes to primary operator screens.

Test Plan

  • go test -race ./cmd/detent ./internal/cli ./internal/tui ./internal/web -count=1
  • make check

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 54dbd3265e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/cli/shutdown.go Outdated
@corylanou
corylanou force-pushed the detent/detent-digitaldrywood_detent_1484-7f26a6810dec branch from 1ddd03d to 821ae43 Compare July 22, 2026 15:37
@corylanou
corylanou merged commit f590261 into main Jul 22, 2026
11 checks passed
@corylanou
corylanou deleted the detent/detent-digitaldrywood_detent_1484-7f26a6810dec branch July 22, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

regression(shutdown): draining /health hangs and forced SIGTERM is reported as github_auth

1 participant