fix(shutdown): stabilize drain teardown#1487
Merged
corylanou merged 3 commits intoJul 22, 2026
Merged
Conversation
corylanou
marked this pull request as ready for review
July 22, 2026 15:03
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 54dbd3265e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
corylanou
force-pushed
the
detent/detent-digitaldrywood_detent_1484-7f26a6810dec
branch
from
July 22, 2026 15:37
1ddd03d to
821ae43
Compare
corylanou
deleted the
detent/detent-digitaldrywood_detent_1484-7f26a6810dec
branch
July 22, 2026 15:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1484
UI Surface Contract
Test Plan
go test -race ./cmd/detent ./internal/cli ./internal/tui ./internal/web -count=1make check