Skip to content

add guidance to hard code local plan doc #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pooleycodes merged 2 commits into from
Jul 31, 2026
Merged

add guidance to hard code local plan doc #1242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96ad399
add guidance to hard code local plan doc
pooleycodes Jul 30, 2026
fccb96c
applye BEM
pooleycodes Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
208 changes: 168 additions & 40 deletions config/plan-fallback.json
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions src/assets/scss/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,11 @@ code * {
max-width: 100%;
}

.app-issue-guidance__markdown img {
max-width: 100%;
height: auto;
}
Comment thread
pooleycodes marked this conversation as resolved.

.schema-issue {
display: flex;
flex-direction: column;
Expand Down
96 changes: 96 additions & 0 deletions src/assets/static/images/plan-timetable-plan-relationship.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion src/content/allRowsIssueMessages.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,4 @@ issue_type,allRows_message,dataset
"missing associated entity","{column_name} column must match the reference field in the tree preservation order dataset",tree-preservation-order
"missing associated entity","{column_name} column must match the reference field in the tree preservation order dataset",tree-preservation-zone
"missing associated entity","{column_name} column must match the reference field in the tree preservation order dataset",tree
"missing associated entity","{column_name} column must match the reference field in the relevant plan dataset",plan-timetable
"missing associated entity","All ‘{column_name}’ fields do not match the ‘reference’ field in the plan dataset",plan-timetable
2 changes: 1 addition & 1 deletion src/content/entityIssueMessages.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ issue_type,singular_message,plural_message,dataset
"missing associated entity","1 entry with tree-preservation-order field must match the reference field in the tree preservation order dataset","{num_entries} entries with tree-preservation-order field must match the reference field in the tree preservation order dataset",tree-preservation-order
"missing associated entity","1 entry with tree-preservation-order field must match the reference field in the tree preservation order dataset","{num_entries} entries with tree-preservation-order field must match the reference field in the tree preservation order dataset",tree-preservation-zone
"missing associated entity","1 entry with tree-preservation-order field must match the reference field in the tree preservation order","{num_entries} entries with tree-preservation-order field must match the reference field in the tree preservation order",tree
"missing associated entity","1 entry with plan field must match the reference field in the relevant plan","{num_entries} entries with plan field must match the reference field in the relevant plan",plan-timetable
"missing associated entity","1 ‘{column_name}’ field does not match the ‘reference’ field in the plan dataset","{num_entries} ‘{column_name}’ fields do not match the ‘reference’ field in the plan dataset",plan-timetable
2 changes: 1 addition & 1 deletion src/content/fieldIssueMessages.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ issue_type,singular_message,plural_message,dataset
"missing associated entity","{column_name} must match the reference field in the tree preservation order dataset","{num_entries} entries with {column_name} field must match the reference field in the tree preservation order dataset",tree-preservation-order
"missing associated entity","{column_name} must match the reference field in the tree preservation order dataset","{num_entries} entries with {column_name} field must match the reference field in the tree preservation order dataset",tree-preservation-zone
"missing associated entity","{column_name} must match the reference field in the tree preservation order","{num_entries} entries with {column_name} field must match the reference field in the tree preservation order",tree
"missing associated entity","{column_name} must match the reference field in the relevant plan","{num_entries} entries with {column_name} field must match the reference field in the relevant plan",plan-timetable
"missing associated entity","‘{column_name}’ field does not match the ‘reference’ field in the plan dataset","{num_entries} ‘{column_name}’ fields do not match the ‘reference’ field in the plan dataset",plan-timetable
6 changes: 4 additions & 2 deletions src/views/includes/_issue-guidance.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@

{% if issueSpecification %}
{% set issueSpecificationInsetHtml %}
<div>
<div class="app-issue-guidance">
<h3 class="govuk-heading-m">{{ issueSpecification.field }}</h3>

{% if issueSpecification.guidance %}
{{ issueSpecification.guidance | govukMarkdown | safe }}
<div class="app-issue-guidance__markdown">
{{ issueSpecification.guidance | govukMarkdown | safe }}
</div>
{% endif %}
</div>
{% endset %}
Expand Down
Loading