Skip to content

fix: Update asyncRequestApi URL to use HTTPS for improved security - #1227

Merged
pooleycodes merged 3 commits into
mainfrom
fix/async-url
Jul 10, 2026
Merged

fix: Update asyncRequestApi URL to use HTTPS for improved security#1227
pooleycodes merged 3 commits into
mainfrom
fix/async-url

Conversation

@gibahjoe

@gibahjoe gibahjoe commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

changed config for asyncRequestApi to https://pub-async.development.planning.data.gov.uk/

Summary by CodeRabbit

  • Chores
    • Updated the async request API endpoint across staging, acceptance tests, development, and production to use secure https URLs instead of the previous HTTP load balancer addresses.

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a3df79b3-119c-4a46-9bb0-fc3f8f8b9d17

📥 Commits

Reviewing files that changed from the base of the PR and between 0c454f2 and c56ba66.

📒 Files selected for processing (4)
  • config/acceptanceTests.yaml
  • config/development.yaml
  • config/production.yaml
  • config/staging.yaml

Walkthrough

All environment configurations now point asyncRequestApi.url to HTTPS endpoints under planning.data.gov.uk, replacing the previous HTTP ELB hostnames.

Changes

Async request API configuration

Layer / File(s) Summary
Update environment API endpoints
config/acceptanceTests.yaml, config/development.yaml, config/production.yaml, config/staging.yaml
Replaces HTTP ELB URLs with environment-specific HTTPS planning.data.gov.uk endpoints.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Poem

Four HTTPS paths now bloom,
No ELB shadows in the room.
A bunny hops through configs bright,
And thumps approval for secure flight! 🐇🔒

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarises the main change: switching asyncRequestApi URLs to HTTPS for security.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/async-url

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 70.98% 2540 / 3578
🔵 Statements 70.14% 2679 / 3819
🔵 Functions 64.13% 506 / 789
🔵 Branches 63.97% 1250 / 1954
File CoverageNo changed files found.
Generated in workflow #1553 for commit c56ba66 by the Vitest Coverage Report Action

@ernest-tpximpact ernest-tpximpact left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pooleycodes
pooleycodes merged commit 237ebaa into main Jul 10, 2026
5 checks passed
@pooleycodes
pooleycodes deleted the fix/async-url branch July 10, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants