Add LPA Dashboard link to CheckAnswersController - #1214
Conversation
|
Warning Review limit reached
Next review available in: 24 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughA single line is added to the Jira issue description template in ChangesJira Description Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/controllers/CheckAnswersController.js (1)
113-113: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd a unit assertion for the new dashboard URL.
test/unit/checkAnswersController.test.js:113-142already checks the generated Jira description, so it would be worth extending that spec to assert this new line as well and keep the new behaviour covered.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/controllers/CheckAnswersController.js` at line 113, The Jira description now includes a new LPA Dashboard URL line, but the unit test coverage does not assert it. Extend the existing checkAnswersController spec for the description-building logic in CheckAnswersController to verify the new dashboard URL appears in the generated Jira description alongside the existing assertions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/controllers/CheckAnswersController.js`:
- Line 113: The Jira description now includes a new LPA Dashboard URL line, but
the unit test coverage does not assert it. Extend the existing
checkAnswersController spec for the description-building logic in
CheckAnswersController to verify the new dashboard URL appears in the generated
Jira description alongside the existing assertions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 5154da2e-9697-44b6-a849-1f542a928fb5
📒 Files selected for processing (1)
src/controllers/CheckAnswersController.js
Added expectation for LPA Dashboard URL in the test case.
| - Email: ${data.email}\n | ||
| - Organisation ID: ${data.organisationId}\n | ||
| - Organisation Name: ${data.organisationName}\n | ||
| - LPA Dashboard: https://provide.planning.data.gov.uk/organisations/${data.organisationId}\n |
There was a problem hiding this comment.
This should use the config like below so it is environment aware
GitHub Actions
Failure
gibahjoe
left a comment
gibahjoe
left a comment
There was a problem hiding this comment.
LGTM. If @pooleycodes is done with his test.
pooleycodes
left a comment
pooleycodes
left a comment
There was a problem hiding this comment.
yep test in local works fine
3 participants
Description
Adds the link to the LPA Dashboard into the JIRA ticket.
What type of PR is this? (check all applicable)
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Before
Before screenshot here
After
After screenshot here
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
QA sign off
[optional] Are there any post-deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?
Summary by CodeRabbit