Skip to content

Fix incorrect page number in check results URL and update related tes… #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gibahjoe merged 1 commit into from
Jun 11, 2026
+9 −5
Merged

Fix incorrect page number in check results URL and update related tes… #1206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/controllers/CheckAnswersController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class CheckAnswersController extends PageController {
const datasetMeta = datasets.get(dataset) || {} // eslint-disable-line no-unused-vars
const requestId = req.sessionModel.get('requestId')
const checkTool = requestId
? `${config.url}check/results/${requestId}/${config.jira.requestTypeId}`
? `${config.url}check/results/${requestId}/1`
: 'Check tool link unavailable'

const isNonProd = ['local', 'development', 'staging'].includes(config.environment)
Expand Down
12 changes: 8 additions & 4 deletions test/unit/checkAnswersController.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ describe('CheckAnswersController', () => {

describe('createJiraServiceRequest', () => {
it('should create a Jira service request using the existing requestId and attach a file', async () => {
config.jira.requestTypeId = '1'
config.jira.requestTypeId = '28'
req.sessionModel.get.mockImplementation((key) => sessionData[key])

const response = { data: { issueKey: 'TEST-123' } }
Expand All @@ -96,6 +96,10 @@ describe('CheckAnswersController', () => {

const result = await controller.createJiraServiceRequest(req, res, next)

const [jiraRequest, jiraRequestTypeId] = createCustomerRequest.mock.calls[0]
expect(jiraRequest.description).toContain(`${config.url}check/results/existing-request-id/1`)
expect(jiraRequest.description).not.toContain(`${config.url}check/results/existing-request-id/${config.jira.requestTypeId}`)
expect(jiraRequestTypeId).toBe(config.jira.requestTypeId)
expect(createCustomerRequest).toHaveBeenCalledWith(
expect.objectContaining({
description: expect.stringContaining(`${config.url}check/results/existing-request-id/1`)
Expand Down Expand Up @@ -148,7 +152,7 @@ describe('CheckAnswersController', () => {
})

it('should add geometry type for dataset tree', async () => {
config.jira.requestTypeId = '1'
config.jira.requestTypeId = '28'
req.sessionModel.get.mockImplementation((key) => ({ ...sessionData, dataset: 'tree', geomType: 'polygon' })[key])
const response = { data: { issueKey: 'TEST-123' } }
createCustomerRequest.mockResolvedValue(response)
Expand All @@ -166,7 +170,7 @@ describe('CheckAnswersController', () => {
})

it('should include plugin in CSV attachment when plugin is retrieved', async () => {
config.jira.requestTypeId = '1'
config.jira.requestTypeId = '28'
const mockRequestData = { getPlugin: vi.fn().mockReturnValue('wfs'), isComplete: vi.fn().mockReturnValue(true) }
getRequestData.mockResolvedValue(mockRequestData)
req.sessionModel.get.mockImplementation((key) => sessionData[key])
Expand All @@ -188,7 +192,7 @@ describe('CheckAnswersController', () => {
})

it('should not include geometry type when dataset is not tree', async () => {
config.jira.requestTypeId = '1'
config.jira.requestTypeId = '28'
req.sessionModel.get.mockImplementation((key) => ({ ...sessionData, dataset: 'conservation-area', geomType: 'polygon' })[key])
const response = { data: { issueKey: 'TEST-123' } }
createCustomerRequest.mockResolvedValue(response)
Expand Down
Loading