combine error and issue counts into a single total - #1073
Merged
Conversation
Contributor
WalkthroughThe changes update dataset statistics handling by explicitly tracking and aggregating endpoint error counts alongside issue counts. Schema definitions, middleware logic, UI templates, and unit tests are revised to compute, store, and display the combined total of issues and endpoint errors for each dataset. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI (overview.html)
participant Middleware
participant Schema
User->>UI (overview.html): Request organisation overview
UI (overview.html)->>Middleware: Fetch dataset statistics
Middleware->>Schema: Validate dataset objects (including endpointErrorCount)
Middleware->>Middleware: Compute issueCount + endpointErrorCount
Middleware->>UI (overview.html): Return datasets with aggregated counts
UI (overview.html)->>User: Display total issues (issues + endpoint errors)
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
DilwoarH
previously approved these changes
Jul 11, 2025
DilwoarH
left a comment
DilwoarH
left a comment
Contributor
There was a problem hiding this comment.
Technical implementation looks fine - do a final check with product to ensure the correct things are showing
DilwoarH
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR combine error and issue counts into a single total.
What type of PR is this? (check all applicable)
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Before
Before screenshot here
After
After screenshot here
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
QA sign off
[optional] Are there any post-deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?
Summary by CodeRabbit