Remove start pages

src/controllers/lpaDetailsController.js

@@ -3,8 +3,11 @@ import { fetchLocalAuthorities } from '../utils/datasetteQueries/fetchLocalAutho
 
 class LpaDetailsController extends PageController {
   async locals (req, res, next) {
-    const localAuthoritiesNames = await fetchLocalAuthorities()
+    if (!req.sessionModel?.get('lpa') || !req.sessionModel?.get('dataset')) {
+      return res.redirect('/')
+    }
 
+    const localAuthoritiesNames = await fetchLocalAuthorities()
     const listItems = localAuthoritiesNames.map(name => ({
       text: name,
       value: name

src/routes/form-wizard/check/steps.js

@@ -25,7 +25,6 @@ export default {
     entryPoint: true,
     resetJourney: true,
     next: 'dataset',
-    template: 'check/start.html',
     noPost: true
   },
   '/dataset': {

src/routes/form-wizard/endpoint-submission-form/steps.js

@@ -26,7 +26,6 @@ export default {
     fields: ['name', 'email'],
     next: 'dataset-details',
     controller: LpaDetailsController,
-    backLink: '/start',
     checkJourney: false
   },
   '/dataset-details': {

test/unit/lpaDetailsController.test.js

@@ -25,15 +25,24 @@ describe('lpaDetailsController', async () => {
   })
 
   describe('locals', () => {
-    it('should set localAuthorities options in the form', async () => {
-      const req = {
+    let req, res, next
+    beforeEach(() => {
+      req = {
         form: {
           options: {}
+        },
+        sessionModel: {
+          get: vi.fn((key) => {
+            if (key === 'lpa' || key === 'dataset') return 'mock-value'
+            return undefined
+          })
         }
       }
-      const res = {}
-      const next = vi.fn()
+      res = { redirect: vi.fn() }
+      next = vi.fn()
+    })
 
+    it('should set localAuthorities options in the form', async () => {
       const localAuthoritiesNames = ['Authority 1', 'Authority 2']
 
       fetchLocalAuthorities.fetchLocalAuthorities = vi.fn().mockResolvedValue(localAuthoritiesNames)
@@ -49,20 +58,38 @@ describe('lpaDetailsController', async () => {
     })
 
     it('should call super.locals', async () => {
-      const req = {
-        form: {
-          options: {}
-        }
-      }
-      const res = {}
-      const next = vi.fn()
-
       fetchLocalAuthorities.fetchLocalAuthorities = vi.fn().mockResolvedValue([])
       const superLocalsSpy = vi.spyOn(PageController.prototype, 'locals')
 
       await controller.locals(req, res, next)
 
       expect(superLocalsSpy).toHaveBeenCalledWith(req, res, next)
+      expect(res.redirect).not.toHaveBeenCalled()
+      expect(next).toHaveBeenCalled()
+    })
+
+    it('should redirect when lpa is missing from session', async () => {
+      req.sessionModel.get = vi.fn((key) => {
+        if (key === 'dataset') return 'mock-value'
+        return undefined
+      })
+
+      await controller.locals(req, res, next)
+
+      expect(res.redirect).toHaveBeenCalledWith('/')
+      expect(next).not.toHaveBeenCalled()
+    })
+
+    it('should redirect when dataset is missing from session', async () => {
+      req.sessionModel.get = vi.fn((key) => {
+        if (key === 'lpa') return 'mock-value'
+        return undefined
+      })
+
+      await controller.locals(req, res, next)
+
+      expect(res.redirect).toHaveBeenCalledWith('/')
+      expect(next).not.toHaveBeenCalled()
     })
   })
 })