Skip to content

Fix smoke test: Remove invalid chars from string interpolation - #395

Open
cpcundill wants to merge 5 commits into
mainfrom
fix/smoke-test-invalid-chars-string-interpolation
Open

Fix smoke test: Remove invalid chars from string interpolation#395
cpcundill wants to merge 5 commits into
mainfrom
fix/smoke-test-invalid-chars-string-interpolation

Conversation

@cpcundill

Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Removed invalid chars from screenshot path string interpolation in smoke tests

Related Tickets & Documents

  • Ticket Link: None - incidental issue found while working on other tasks
  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.

  • Yes
  • No, and this is why: need to deploy into dev and staging next for testing
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] Are there any dependencies on other PRs or Work?

@ernest-tpximpact ernest-tpximpact left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…empty file name which was occurring for the root URL path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants