Skip to content

fix: remove stage dependent mandatory fields for plans datasets #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tombrooks248 merged 1 commit into from
Jul 13, 2026
Merged

fix: remove stage dependent mandatory fields for plans datasets #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions digital_land/phase/harmonise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,8 @@
"description",
"dataset",
"period-start-date",
"period-end-date",
"local-planning-authorities",
"documentation-url",
"document-url",
"required-housing",
"entry-date",
],
"supplementary-plan": [
Expand All @@ -103,10 +100,8 @@
"description",
"dataset",
"period-start-date",
"period-end-date",
"local-planning-authorities",
"documentation-url",
"document-url",
"entry-date",
],
"minerals-plan": [
Expand All @@ -115,10 +110,8 @@
"description",
"dataset",
"period-start-date",
"period-end-date",
"minerals-and-waste-planning-authorities",
"documentation-url",
"document-url",
"document-count",
"entry-date",
],
Expand All @@ -128,10 +121,8 @@
"description",
"dataset",
"period-start-date",
"period-end-date",
"minerals-and-waste-planning-authorities",
"documentation-url",
"document-url",
"document-count",
"entry-date",
],
Expand Down
50 changes: 50 additions & 0 deletions tests/unit/phase/test_harmonise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,56 @@ def test_harmonise_missing_mandatory_values():
assert issue["value"] == ""


def test_harmonise_stage_dependent_plan_fields_not_flagged():
# period-end-date, document-url and required-housing are stage-dependent for
# the plan datasets: they should only be required once the LPA has reached
# proposed-plan-consultation-start. They must NOT be flagged as "missing
# value" when blank here — that check moves to a post-build expectation.
issues = IssueLog()
field_datatype_map = {
"reference": "string",
"name": "string",
"description": "string",
"dataset": "string",
"period-start-date": "datetime",
"period-end-date": "datetime",
"local-planning-authorities": "string",
"documentation-url": "url",
"document-url": "url",
"required-housing": "integer",
"entry-date": "datetime",
}

h = HarmonisePhase(
field_datatype_map=field_datatype_map,
issues=issues,
dataset="local-plan",
)
reader = FakeDictReader(
[
{
"reference": "camden-local-plan",
"name": "Camden Local Plan",
"description": "A plan",
"dataset": "local-plan",
"period-start-date": "2020-01-01",
"period-end-date": "",
"local-planning-authorities": "local-authority:CMD",
"documentation-url": "https://example.com/docs",
"document-url": "",
"required-housing": "",
"entry-date": "2026-01-01",
},
],
)
list(h.process(reader))

flagged = {issue["field"] for issue in issues.rows}
assert "period-end-date" not in flagged
assert "document-url" not in flagged
assert "required-housing" not in flagged


def test_get_field_datatype_name_uses_field_datatype_map():
field_datatype_map = {"reference": "string"}
phase = HarmonisePhase(field_datatype_map=field_datatype_map)
Expand Down