fix: free disk space in assemble-and-bake - #569
Merged
Conversation
tombrooks248
marked this pull request as ready for review
June 26, 2026 12:27
p3dr0migue1
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Free up disk space while building the listed-building dataset so it stops crashing.
Add a flag to the tests so that this caching doesn't break the create_dataset test.
Why
The assemble-and-bake task writes a lot of temporary data to disk, which is capped at 200GB. For listed-building it now fills up completely and crashes while building the sqlite file.
This change deletes some temporary files we've already finished with, freeing up space for the rest of the build to complete.
Also fixes a small existing bug in
close_connthat referenced aduckdb_filewhich should beduckdb_path— it wasn't hit before because nothing called it, but this change does.Related Tickets & Documents
QA Instructions, Screenshots, Recordings
I have run this in DEV and it ran fine.
It only saved 0.7GB of data which extrapolated to PROD would result in a 8GB saving out of a 200GB limit so possibly not enough to solve the problem, but worth trying.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.
have not been included
[optional] Are there any post deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?