Raise missing associated entity issue for plan-timetable - #563
Merged
Conversation
salabi
marked this pull request as ready for review
June 12, 2026 11:59
tombrooks248
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Raise missing associated entity issue for plan-timetable.
Because plan is a package dataset rather than a concrete resource/dataset, issue-type is not raise when there is a missing association entity. We need to adjust the specification to lookup in the resource that Plan was made from and report a missing association entity if none matched just like other normal resource.
Change details as follow
digital_land/phase/lookup.py
digital-land-python/digital_land/pipeline/main.py
digital-land-python/digital_land/specification.py
test_lookup.py
test_specification.py
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
This was tested by running local-plan collection locally and one example of the resource that raise a missing association entity is
dataset,resource,line-number,entry-number,field,entity,issue-type,value,message
plan-timetable,95b1fb985e0573bc4a658c3d9980716d0a66c37db750ca5a71b4a3b8875b2e9f,2,1,plan,5109768,missing associated entity,county-durham-plan,
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.
have not been included
[optional] Are there any post deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?