Skip to content

fix convert test file comparison - #562

Merged
salabi merged 2 commits into
mainfrom
fix_test_covert_csv_comparison
Jun 11, 2026
Merged

fix convert test file comparison#562
salabi merged 2 commits into
mainfrom
fix_test_covert_csv_comparison

Conversation

@salabi

@salabi salabi commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Refactor convert integration tests to avoid byte full golden CSV comparisons.

The tests now validate expected columns, row counts, and relevant field values while tolerating non-functional GDAL output differences such as column ordering, extra columns, and whitespace formatting.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] Are there any dependencies on other PRs or Work?

@salabi
salabi requested a review from gibahjoe June 10, 2026 08:33
@salabi
salabi marked this pull request as ready for review June 10, 2026 08:33

@gibahjoe gibahjoe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salabi
salabi merged commit fb9f001 into main Jun 11, 2026
5 checks passed
@salabi
salabi deleted the fix_test_covert_csv_comparison branch June 11, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants