Skip to content

Expectation tests to unit tests folder - #561

Merged
salabi merged 4 commits into
mainfrom
expectation_tests_to_unit_tests_folder
Jun 8, 2026
Merged

Expectation tests to unit tests folder#561
salabi merged 4 commits into
mainfrom
expectation_tests_to_unit_tests_folder

Conversation

@salabi

@salabi salabi commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Moves pure DatasetCheckpoint tests out of the integration test folder into tests/unit/expectations/checkpoints/test_dataset.py.

The integration file now only contains tests that exercise real spatialite-backed database behaviour. The moved unit tests keep the same logic and names

  • test_get_rule_orgs
  • test_parse_rule_formates_strings
  • test_load_success
  • test_load_skips_rule_not_scheduled_today
  • test_load_includes_rule_scheduled_for_today
  • test_save_carries_forward_skipped_rule_results
  • test_save_skipped_rule_no_existing_parquet
  • test_save_to_parquet

Related Tickets & Documents

  • Ticket Link
  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] Are there any dependencies on other PRs or Work?

@salabi
salabi marked this pull request as ready for review June 8, 2026 10:43
@salabi
salabi requested a review from tombrooks248 June 8, 2026 10:43
@salabi
salabi merged commit 10f06a1 into main Jun 8, 2026
5 checks passed
@salabi
salabi deleted the expectation_tests_to_unit_tests_folder branch June 8, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants