Skip to content

feat: add Saturday schedule for tree and tpz expectations - #2612

Merged
tombrooks248 merged 3 commits into
mainfrom
feat/add-saturday-schedule-for-tree-expectations
May 19, 2026
Merged

feat: add Saturday schedule for tree and tpz expectations#2612
tombrooks248 merged 3 commits into
mainfrom
feat/add-saturday-schedule-for-tree-expectations

Conversation

@tombrooks248

@tombrooks248 tombrooks248 commented May 19, 2026

Copy link
Copy Markdown
Contributor

Summary of code changes

It looks like a big change but all its actually doing is:
Adding in a schedule field for all expect.csv, and ending comma for each line so that csv rule is met.

Setting a schedule of "saturday" for tree, tree-protection-zone, listed-building-outline and article-4-direction-area on duplicate_geometry_check.

Why

This will enable us to set schedules of when particular long running expectations run so we can for example set them to run at weekends

Ticket

Type

  • New data
  • Data monitoring
  • Data fix

Data updated (list organisation and dataset):

  • Dataset: expect.csv - for tree and tree-protection-zone

Expected outcome (if relevant):

  • New endpoint & source
  • New lookups
  • Extra endpoint config (e.g. column, concat)
  • Retired old endpoint & source
  • Retired old entities
  • Retired old resource
  • Make it possible for duplicate_geometry_check to be only run on saturdays

Additional information:
This is linked to this PR for digital-land-python

Tests
I have done a full run through of ancient-woodland locally and it seems to run as expected.

Requester's checklist:

  • Have checked if any old endpoints to retire
  • Have validated endpoint (with check or endpoint checker)
  • Have checked expected number of lookups
  • Have checked for any geo duplicates (if CA data)
  • Have updated entity-organisation.csv (if CA data)

Reviewer's checklist:

  • Expected checks have been completed by PR requester
  • Correct date format used in config files (YYYY-mm-dd)
  • Number of new lookups is as expected from source data
  • Spot checked that newly assigned entity numbers aren’t in use

@salabi salabi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants