fix assmble.sh to only retain expectations file for the collection it… - #59
Merged
tombrooks248 merged 2 commits intoJun 1, 2026
Merged
Conversation
tombrooks248
force-pushed
the
fix/only-upload-collection-specific-expectation-logs
branch
from
June 1, 2026 13:02
cd88200 to
fd5e59c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Edit the retain duplicate_geometry_checks code so that it only brings in the expectations for that specific collection not for all collections.
Why
When I originally created this change I was not specific enough and expectations were being downloded for sister collections e.g. the area-of-ourstanding-natural-beauty was downloading expectations parquet file article-4-direction-area file and later on when these files were synced back with the s3 bucket in some cases the code was updating expectations parquet files from other collections. This fix will prevent this from happening.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.
I have deployed this to Dev and ran 3 differnt pipelines and I am happy that this make the change I am intending to make.
[optional] Are there any post deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?