Skip to content

Reversed adding refill todays logs code changes #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexglasertpx wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Reversed adding refill todays logs code changes #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b861ee0
Reversed adding refill todays logs code changes
alexglasertpx Jan 23, 2025
a0a5c5e
Merge branch 'main' into refill_todays_logs
alexglasertpx Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions dags/collection_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
"dataset-jobs": Param(default=8, type="integer"),
"incremental-loading-override": Param(default=False, type="boolean"),
"regenerate-log-override": Param(default=True, type="boolean"),
"refill-todays-logs": Param(default=False, type="boolean"),
},
render_template_as_native_obj=True,
is_paused_upon_creation=False,
Expand Down Expand Up @@ -94,8 +93,7 @@
{"name": "TRANSFORMED_JOBS", "value":"'{{ task_instance.xcom_pull(task_ids=\"configure-dag\", key=\"transformed-jobs\") | string }}'"},
{"name": "DATASET_JOBS", "value": "'{{ task_instance.xcom_pull(task_ids=\"configure-dag\", key=\"dataset-jobs\") | string }}'"},
{"name": "INCREMENTAL_LOADING_OVERRIDE", "value": "'{{ task_instance.xcom_pull(task_ids=\"configure-dag\", key=\"incremental-loading-override\") | string }}'"},
{"name": "REGENERATE_LOG_OVERRIDE", "value": "'{{ task_instance.xcom_pull(task_ids=\"configure-dag\", key=\"regenerate-log-override\") | string }}'"},
{"name": "REFILL_TODAYS_LOGS", "value": "'{{ task_instance.xcom_pull(task_ids=\"configure-dag\", key=\"refill-todays-logs\") | string }}'"}
{"name": "REGENERATE_LOG_OVERRIDE", "value": "'{{ task_instance.xcom_pull(task_ids=\"configure-dag\", key=\"regenerate-log-override\") | string }}'"}
],
},
]
Expand Down
2 changes: 0 additions & 2 deletions dags/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ def configure_dag(**kwargs):
dataset_jobs = str(kwargs['params'].get('dataset-jobs'))
incremental_loading_override = bool(kwargs['params'].get('incremental-loading-override'))
regenerate_log_override = bool(kwargs['params'].get('regenerate-log-override'))
refill_todays_logs = bool(kwargs['params'].get('refill-todays-logs'))

# get ecs-task logging configuration
ecs_client = boto3.client('ecs')
Expand All @@ -117,6 +116,5 @@ def configure_dag(**kwargs):
ti.xcom_push(key='collection-dataset-bucket-name', value=collection_dataset_bucket_name)
ti.xcom_push(key='incremental-loading-override', value=incremental_loading_override)
ti.xcom_push(key='regenerate-log-override', value=regenerate_log_override)
ti.xcom_push(key='refill-todays-logs', value=refill_todays_logs)

return configure_dag