Add uncertainties for main parameters.#299
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 24 24
Lines 1480 1523 +43
=======================================
+ Hits 1479 1522 +43
Misses 1 1
🚀 New features to boost your workflow:
|
|
Oops, previous one I ran only one of the tests I thought would be affected... fixed now. |
sbillinge
left a comment
There was a problem hiding this comment.
looks great. One inline comment.
| f"# {param} = {morph_results[target][param]:.6f}" | ||
| for param in morph_results[target] | ||
| ) | ||
| # output += "# Optimized morphing parameters:\n" |
There was a problem hiding this comment.
are you retaining these lines for some reason? If yes, state the reason and when they can be removed, and if not, then just remove them.
There was a problem hiding this comment.
Ah, thanks. I left that there as reference for a different approach originally.
|
@sbillinge Removed the stray comment. Since pre-commit isn't working on here (we will address by #301 hopefully), this screenshot is just to confirm it is passing it locally. |




Closes #300
Need tests for warnings and each parameter separately (including baselineslope).
Need special handling for
squeezeandfunc[x/y/xy]morph parameters.