web: Add login via GitHub#7
Merged
Merged
Conversation
PLukas2018
force-pushed
the
login
branch
2 times, most recently
from
e0c35fd to
8743c27
Compare
This commit adds log in via GitHub using GitHub App OAuth [1]. This is added to allow in the future editing of expected results by certain users. [1] https://docs.github.com/en/apps/creating-github-apps/writing-code-for-a-github-app/building-a-login-with-github-button-with-a-github-app
Update the docs to include info about the db migration and .env file.
Collaborator
Author
|
Fixed issues. Changed from log in via GitHub OAuth to GitHub App which allows more fine-grained permissions, but otherwise it should be almost the same (the mechanism should still use OAuth but it is created by the GitHub App). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds log in via GitHub using GitHub OAuth. This is added to allow (in the future) editing of the expected results by certain users.
The commit also updates the docs.