Centralize OpenWork runtime DB#2071
Open
benjaminshafii wants to merge 1 commit into
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
1 issue found across 10 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/server/src/runtime-db.ts">
<violation number="1" location="apps/server/src/runtime-db.ts:208">
P2: DB open cache set too late. Race can open same path twice, and failed open gets stuck in cache. Store a single in-flight promise before await and clear cache on reject.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| const path = runtimeDbPath(config); | ||
| const existing = dbByPath.get(path); | ||
| if (existing) return existing; | ||
| await ensureDir(dirname(path)); |
There was a problem hiding this comment.
P2: DB open cache set too late. Race can open same path twice, and failed open gets stuck in cache. Store a single in-flight promise before await and clear cache on reject.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/server/src/runtime-db.ts, line 208:
<comment>DB open cache set too late. Race can open same path twice, and failed open gets stuck in cache. Store a single in-flight promise before await and clear cache on reject.</comment>
<file context>
@@ -0,0 +1,240 @@
+ const path = runtimeDbPath(config);
+ const existing = dbByPath.get(path);
+ if (existing) return existing;
+ await ensureDir(dirname(path));
+ const db = typeof process.versions.bun === "string" ? openBunRuntimeDb(path) : openNodeRuntimeDb(path);
+ dbByPath.set(path, db);
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
E2E eval coverage