Conversation
The ChimeraX step used a silent `curl -s | grep` pipeline whose exit status is grep's: an empty or unexpected response (e.g. blocked egress from the Harbor builder) makes grep match nothing and exit 1, aborting the build with a bare "exit code 1" and zero diagnostics -- which is exactly how it failed in CI run 28394997476. Run the token dance under bash with set -euo pipefail and curl -fsS so HTTP/network errors surface, retry transient failures, print the raw response when no download URL is found, and gate apt-get install behind dpkg-deb --info so a non-.deb payload is reported instead of silently breaking the install.
Fix/chimerax download robust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.