feat(blog): poetic editorial pilot + new content engine case#22
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @diegovfeder's task —— View job Pull Request ReviewReview Tasks
✅ Overall AssessmentThis is a well-executed editorial overhaul that introduces a clear content strategy with strong technical implementation. The changes demonstrate excellent attention to both content quality and code standards. 📝 Content Quality ReviewEditorial Specification DocumentsExcellent foundation work:
Blog Post AnalysisAll three posts follow the new specification perfectly: Word Count Compliance:
Structure Compliance:
🔧 Code Quality ReviewBlog Metadata (
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
* design-system: add DESIGN.md (YAML tokens + brand rationale) as the canonical spec for any UI work; wire it into CLAUDE.md, AGENTS.md, and AI_INDEX.md as a bootstrap reference. * brag route: split the monolithic /brag dump into a scannable landing (recent evidence + yearly docs + explore links), /brag/profile (positioning, highlights, strengths, focus areas, skill groups, languages, preferred roles, timeline), /brag/toolkit (prompt templates + generated artifacts), and a restyled /brag/[year]. Shared BragHeader + BragNav sub-nav; every surface now follows DESIGN.md (border-2, rounded-lg, mono voice, no gradients/glass). * nav: replace the top-right floating pill stack (BlogNavButton) with a global Footer (dvf. brand stamp + mono outline route links); drop the bottom brag_document. CTA from the home route. * fix(lazy-image): bulletproof hydration load detection (callback ref + microtask + rAF fallback + onError) and pointer-events-none on the skeleton and the <img> so cached images stop being stuck behind the placeholder and Corvu dialog triggers open again on cases/projects. * docs: refresh CLAUDE.md, AGENTS.md, README.md, and AI_INDEX.md; remove .cursorrules and migrate the SolidJS/a11y/handler conventions into CLAUDE.md; add the 2026-03-13 forensics delta snapshot. * content: stage new blog posts, brag manifest profile, yearly brag reports (2025, 2026), and the brag-workflow + blog-create-post repo-local skills. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Claude finished @diegovfeder's task —— View job ✅ Pull Request Review CompleteOverall AssessmentThis is an excellent, comprehensive feature addition that introduces a sophisticated blog editorial system, AI-powered chat functionality, and structured brag documentation. The implementation demonstrates strong engineering practices with excellent security, performance, and maintainability considerations. 🔒 Security Review - EXCELLENTChat API Security (
Potential Security Improvements:
⚡ Performance Review - VERY GOODPositive Optimizations:
Performance Considerations:
🧪 Test Coverage Review - EXCELLENTComprehensive Test Suite:
Test Quality Highlights:
📝 Code Quality Review - EXCELLENTEditorial SystemBlog specification documents create a sustainable content framework:
TypeScript Quality
SolidJS Conventions
🐛 Issues FoundMinor Issues
Recommendations
🚀 Feature Quality AssessmentBlog Editorial System
AI Chat System
Brag Documentation System
📊 Architecture AssessmentStrengths
Future Considerations
✅ Final Recommendation: APPROVEThis PR represents a significant upgrade to the portfolio with excellent technical execution. The new features are well-architected, thoroughly tested, and follow security best practices. The editorial system creates a sustainable content strategy while the technical implementation remains robust. Key Achievements:
The codebase is ready for production deployment. |
Review Summary by QodoPortfolio expansion: brag system, chat API, blog editorial refresh, and comprehensive documentation
WalkthroughsDescription**Major portfolio expansion with brag system, chat integration, and blog editorial refresh** • Introduced comprehensive /brag route system with profile, yearly reports, toolkit, and evidence aggregation • Built DeepSeek-powered /chat route with persona context, security guards, rate limiting, and full test coverage • Refactored blog editorial with poetic voice rewrite, new content engine case study, and metadata structure • Created extensive documentation: design system (DESIGN.md), agent bootstrap guides (CLAUDE.md, AGENTS.md), forensics snapshots, and brag templates • Added 8 new blog posts covering AI agents, system design, SEO, and frontend excellence • Implemented career evidence system mapping blog posts to brag metadata with impact statements and interview angles • Set up Vitest test infrastructure with 15+ new test suites covering routes, components, utilities, and API endpoints • Enhanced core components: Footer with cross-route nav, LazyImage hydration fixes, theme context improvements • Established repo-local skills framework for blog creation and brag workflows with reusable prompts • Added codebase forensics baseline and delta reports for AI assistant context and session bootstrap Diagramflowchart LR
Blog["Blog Posts<br/>8 new + rewrites"]
BragData["Brag Data<br/>Profile/Timeline/Reports"]
BragRoutes["Brag Routes<br/>/brag, /profile, /toolkit, /year"]
ChatAPI["Chat API<br/>DeepSeek + Security"]
ChatRoute["Chat Route<br/>/chat UI"]
Persona["AI Persona<br/>Context Builder"]
Tests["Test Suites<br/>15+ coverage"]
Docs["Documentation<br/>Design/Guides/Forensics"]
Blog -->|Evidence| BragData
BragData -->|Render| BragRoutes
ChatAPI -->|Powers| ChatRoute
BragData -->|Context| Persona
Persona -->|Grounds| ChatRoute
BragRoutes -->|Tested by| Tests
ChatRoute -->|Tested by| Tests
Blog -->|Documented in| Docs
BragRoutes -->|Documented in| Docs
File Changes1. src/utils/blog.ts
|
Code Review by Qodo
1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
…yImage, polish nav/footer/contact * fix(entry-client): call mount() at module top-level instead of wrapping it in a default export that was never invoked. This was the silent hydration failure that killed every click handler on the home route (theme toggle, projects toggle, Corvu Dialog) and made LazyImage's loaded() signal stick at false. * fix(lazy-image): drop the loaded() signal + skeleton overlay entirely and use a neutral gray wrapper background with the image rendered on top. No JS state, no race conditions during SSR hydration, and pointer-events-none on the <img> so cases + projects dialog triggers open cleanly. * refactor(nav): mobile rail tightened (w-12, p-1, pl-6, min-h-[420px]) while keeping desktop unchanged; rotated mono links bumped to text-base sm:text-lg; 5 hard-coded link blocks collapsed into a <For> over a NAV_LINKS array and isActive moved to classList directive. * fix(home): home wrapper pl reduced from pl-16 → pl-12 (mobile) to match the slimmer rail; desktop pl-20 unchanged. * fix(footer): remove pl-12 sm:pl-20 from the outer footer so the inner nav is genuinely centered against the viewport. Move the rail clearance to a sm:pl-20 on the dvf. stamp only when on the home route, so dvf. stays clear of the rail without offsetting the centered nav. * fix(contact): add pr-12 sm:pr-0 to the contact section so the GitHub + LinkedIn icon row is symmetrically padded on mobile and lands at the true viewport center instead of pl-12-shifted-right of it. * feat(projects): add Dr. Enor Massoni (Clínica Massoni, Cascavel — dental practice) and Dr. Paulo Araújo (neurosurgeon, Curitiba) to the top of the hidden projects array, with real screenshots captured via Playwright and descriptions grounded in each site's metadata. * docs(prompts): add docs/prompts/DESIGN_MD_AUTHORING_PROMPT.md — a portable metaprompt for authoring DESIGN.md in this or any other repo (format spec + indexing checklist + token extraction rules + quality gates). Wire it into CLAUDE.md, AGENTS.md, and AI_INDEX.md in place of the now-removed CODEBASE_FORENSICS_PROMPT pointer. * chore: remove the abandoned docs/forensics/ directory and the docs/prompts/CODEBASE_FORENSICS_PROMPT.md file (cleaned up out of band; this commit just records the deletions and removes the stale references from the bootstrap docs). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Claude finished @diegovfeder's task —— View job Pull Request ReviewReview Tasks
✅ Overall AssessmentThis is a well-executed editorial overhaul that introduces a clear content strategy with strong technical implementation. The changes demonstrate excellent attention to both content quality and code standards. 📝 Content Quality ReviewEditorial Specification DocumentsExcellent foundation work:
Blog Post AnalysisAll three posts follow the new specification perfectly: Word Count Compliance:
Structure Compliance:
🔧 Code Quality ReviewBlog Metadata (
|
…ighten long-form padding * fix(api): extract every helper, constant, and type from src/routes/api/chat.ts into the new src/utils/chat-api.ts. SolidStart was tree-shaking the route file with `?pick=POST` and stripping all the `export const guardChatRequest = ...` helpers, producing a runtime `ReferenceError: guardChatRequest is not defined` on every POST. The route file is now just the POST handler + thin re-exports kept around so the existing test imports keep working. * feat(home-link): new fixed top-right `home.` pill rendered on every route except `/`. Single click back to the portfolio from blog/chat/ brag/nested pages. * feat(footer): chat. promoted into the FOOTER_LINKS now that the API is working end-to-end; brag. intentionally still hidden until the brag UX restructure (sub-nav simplification + landing reorder) lands. * feat(theme-button): only render on `/`. The fixed bottom-right toggle was visual noise on long-form routes (blog/chat/brag) where it has nothing to balance against. * feat(noindex): `<Meta name="robots" content="noindex, nofollow" />` on /chat and all /brag routes while they iterate. Easy to drop per route when ready to invite indexing. * refactor(brag/nav): normalize trailing slashes when computing the active sub-nav pill, so `brag.` lights up immediately on the /brag → /brag/ Solid index redirect (was waiting for a click). * fix(footer): swap `sm:pl-20` → `sm:ml-20` on the `dvf.` stamp so the rail-clearance lives outside the link's clickable area instead of enlarging the hit target. * fix(contact-section): pr-12 sm:pr-20 so the heading + GitHub/LinkedIn icons sit at the true viewport center on both mobile and desktop (symmetric against the nav rail's pl). * fix(chat-layout): h-[100dvh] instead of min-h-screen on the chat flex column so the message list scrolls inside the card instead of growing it and pushing the form down the page. Aligned the chat wrapper to the long-form route pattern (max-w-7xl, px-4). * fix(blog-index): inline BlogHeader, drop the awkward fixed-top strip + pt-40 spacer hack. BlogHeader's pt-8 → pt-6. * style(padding): tighten the vertical rhythm on every long-form route: py-16 → pt-8 pb-4 on the inner wrapper, pb-28 → pb-8 on the outer, footer mt-16 py-8 → mt-8 py-6. ~160px less dead space between content and viewport bottom across blog/[slug], brag/*, chat. * test(theme-button): mock useLocation so the new home-only Show gate doesn't crash the suite without a Router. * test(brag-route): drop assertions for the removed latest_year and browse_blog_posts. CTAs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Claude encountered an error —— View job Pull Request ReviewI'll conduct a comprehensive review of this pull request covering code quality, security, performance, and test coverage. Review Tasks
Initial AssessmentThis is an impressive, comprehensive feature addition that introduces:
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Claude finished @diegovfeder's task —— View job Pull Request ReviewI've conducted a comprehensive code review of this major feature addition. This is an impressive implementation that introduces blog editorial standards, AI chat functionality, and a brag documentation system. Review Tasks
✅ Overall AssessmentThis is an excellent, comprehensive feature addition that demonstrates strong engineering practices. The implementation introduces sophisticated blog editorial standards, production-ready AI chat functionality, and a structured career documentation system. 🔒 Security Review - EXCELLENTChat API Security (
|
|
Claude finished @diegovfeder's task —— View job Pull Request ReviewI've conducted a comprehensive review of this pull request covering code quality, security, performance, and test coverage. This is an outstanding implementation that demonstrates exceptional engineering practices. Review Tasks
✅ Overall AssessmentThis is an excellent, comprehensive feature addition that introduces sophisticated blog editorial standards, production-ready AI chat functionality, and a structured career documentation system. The implementation demonstrates strong engineering practices with excellent attention to security, performance, and maintainability. 🔒 Security Review - EXCELLENTChat API Security (
|
|
Claude finished @diegovfeder's task —— View job Pull Request ReviewI've conducted a comprehensive review of this pull request covering code quality, security, performance, and test coverage. This is an outstanding implementation that demonstrates exceptional engineering practices. Review Tasks
✅ Overall AssessmentThis is an excellent, comprehensive feature addition that introduces sophisticated blog editorial standards, production-ready AI chat functionality, and a structured career documentation system. The implementation demonstrates strong engineering practices with excellent attention to security, performance, and maintainability. 🔒 Security Review - EXCELLENTChat API Security (
|
|
Claude finished @diegovfeder's task —— View job Pull Request ReviewI've conducted a comprehensive review of this pull request covering code quality, security, performance, and test coverage. This is an outstanding implementation that demonstrates exceptional engineering practices. Review Tasks
✅ Overall AssessmentThis is an excellent, comprehensive feature addition that introduces sophisticated blog editorial standards, production-ready AI chat functionality, and a structured career documentation system. The implementation demonstrates strong engineering practices with excellent attention to security, performance, and maintainability. 🔒 Security Review - EXCELLENTChat API Security (
|
|
Claude finished @diegovfeder's task —— View job Pull Request ReviewI've conducted a comprehensive code review of this major feature addition covering code quality, security, performance, and test coverage. This is an outstanding implementation that demonstrates exceptional engineering practices. Review Tasks
✅ Overall AssessmentThis is an excellent, comprehensive feature addition that introduces sophisticated blog editorial standards, production-ready AI chat functionality, and a structured career documentation system. The implementation demonstrates strong engineering practices with excellent attention to security, performance, and maintainability. 🔒 Security Review - EXCELLENTChat API Security (
|
|
Claude finished @diegovfeder's task —— View job Pull Request ReviewI've conducted a comprehensive code review of this major feature addition covering code quality, security, performance, and test coverage. This is an outstanding implementation that demonstrates exceptional engineering practices. Review Tasks
✅ Overall AssessmentThis is an excellent, comprehensive feature addition that introduces sophisticated blog editorial standards, production-ready AI chat functionality, and a structured career documentation system. The implementation demonstrates strong engineering practices with excellent attention to security, performance, and maintainability. 🔒 Security Review - EXCELLENTChat API Security (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TELLING_A_GOOD_STORYto remove tutorial-heavy snippets and focus on a personal, practical narrativeFROM_CLIENT_DELIVERY_TO_CONTENT_ENGINE(Notion -> Next.js SEO content SaaS direction)Included Files
docs/BLOG_WRITING_SPEC.mddocs/BLOG_EDITORIAL_QA.mdpublic/blog/posts/LOCAL_SEO_AI_VISIBILITY_CURITIBA_CASE_STUDY.mdpublic/blog/posts/TELLING_A_GOOD_STORY.mdpublic/blog/posts/FROM_CLIENT_DELIVERY_TO_CONTENT_ENGINE.mdsrc/utils/blog.tsValidation
npm run build(passes)/blog/LOCAL_SEO_AI_VISIBILITY_CURITIBA_CASE_STUDY/blog/TELLING_A_GOOD_STORY/blog/FROM_CLIENT_DELIVERY_TO_CONTENT_ENGINE