feat: neutral GitHub change signals from the #23 audit - #24
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8af1b840fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the shortlist from the #23 signal audit (see the audit matrix posted there), plus three classifier-only classes the audit's candidate list did not contemplate. Refs #23.
New delta classes (all additive,
schemaVersionstays 1)Requiring new compared fingerprint fields (
base, PRlabels,assignees,reviewRequests):review-requests-changed(pr) — the core agent-feedback signal; sorted logins, teams asorg/slug,added/removeddetail. No profile payloads: names only, consumers follow up viagh.assignees-changed(pr, issue) — sorted logins,added/removeddetail.base-changed(pr) — PR retargeted; prior CI/mergeability context refers to the old base.relabelednow fires for PRs too (the PR fetch now collects labels; previously issue-only).Classifier-only (existing fingerprint fields, zero fetch cost, id-neutral):
became-conflicting(pr) — inverse ofbecame-mergeable;UNKNOWNmid-recompute still doesn't count.converted-to-draft(pr) — inverse ofdraft-ready.comments-removed(pr, issue) — count decreased; previously an opaqueupdated.Compatibility
mergeStateStatuspairwise rule is generalized to anADDITIVE_COMPARED_FIELDSlist — a snapshot predating a field never fires on its first appearance, and classifiers guard the old side, so a legacy snapshot with a real concurrent change (e.g. a new comment) cannot misfire the new classes. Verified live: a field-stripped snapshot re-run against the real repo produced 0 deltas.to, so each item's id shifts once on its first post-upgrade delta — the documented id policy (ids hash the observed state), not a regression.Verification
npm run checkgreen: lint, format, 281 tests (19 new: fetch normalization + fail-closed pagination, fingerprint sorting/defaults, one detector case per class, both upgrade cases, detail shapes).diegomarino/gh-delta: GraphQL union selection (User/Bot/Mannequin/Team) validates; baseline → idempotent second run (0 deltas) → simulated pre-upgrade snapshot (0 deltas, no burst).Deliberately not included (per the audit)
Review-comment edit detection (the one true blind spot — cost disproportionate, documented as a limitation), thread-state digest (rare offsetting-churn case), milestone/
stateReason/auto-merge/Projects v2 (consumer follow-up from existing deltas).Release notes for 0.5.0 (consumer-facing)
relabelednow also fires for PRs (was documented as issue-only). Route ondelta.entity, never on the class alone. The contract row carries a "was issue-only before 0.5.0" note.to). Monitors on different gh-delta versions emit different ids for the same observation — upgrade co-posting monitors together to keep cross-monitor dedupe intact. Documented in the contract'sidsection.Audit follow-ups folded in (change-audit 2026-08-05)
518331f— Codex P2 / audit X6:updateddetails apply the same additive-field suppression as the detector; no phantomnull -> currentrows on upgrade ticks (now also coversmergeStateStatus).0fc4c0c— X1: RUNBOOK + watch-loop prompt now list all classes (incl.baseline-state) with correctedrelabeledwording; X2/X3 notes in contract.md; X4: GHES schema-age platform note; X7:became-*best-effort caveat; corrected the stale "branch deletion produces no delta" note (deletion bumpsupdatedAt→ opaqueupdated, verified live).f5bb320— README JSON sample regenerated from fixtures now showcasingreview-requests-changed(review approval satisfying the pending request — the documented co-occurrence withreview-changed).