Support/npm fix#30
Open
edunston wants to merge 5 commits into
Open
Conversation
Author
|
Make test not working in local. |
Author
|
I get this new error after the fix: Error: Resolution method is overspecified. Specify a callback or return a Promise; not both. What does it mean? Should I investigate more? |
mrister
approved these changes
Jul 2, 2018
mrister
left a comment
mrister
left a comment
Contributor
There was a problem hiding this comment.
some of these major dependency updates require changes in test code to support, thus the tests fail
Contributor
|
We either will need to invest time in tests and updating them or keep the versions of mocha and chai, basically disregard this PR. |
|
Ok, may I close it then? Or do you prefer it to remain open? @mrister |
Contributor
|
@Spring3 it would be nice to fix the vulnerabilities so let's leave it open |
jkernech
force-pushed
the
support/npm-fix
branch
from
f74f8b8 to
7a246be
Compare
Contributor
|
A bunch of tests are failing, @mrister could you take a look since you are the owner of the project ? Thanks |
Contributor
|
@jkernech will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes: 7/9 vulnerabilities fixed. Bugs were already detected by circle ci before any fix, but the fix using --force added more bug