Assignment#1
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ❌ | rawdata not moved to data/raw |
| Part 1 - Q3 | ✅ | |
| Part 1 - Q4 | ❌ | Missing directories: data/processed/server_logs, data/processed/user_logs, data/processed/event_logs |
| Part 1 - Q5 | ❌ | No server log files in data/raw |
| Part 1 - Q6 | ❌ | No user log files in data/raw; No event log files in data/raw |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ❌ | data/inventory.txt does not exist |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ❌ | rawdata not moved to data/raw |
| Part 1 - Q3 | ✅ | |
| Part 1 - Q4 | ❌ | Missing directories: data/processed/server_logs, data/processed/user_logs, data/processed/event_logs |
| Part 1 - Q5 | ❌ | No server log files in data/raw |
| Part 1 - Q6 | ❌ | No user log files in data/raw; No event log files in data/raw |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ✅ | |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ✅ | |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ✅ | |
| Part 1 - Q6 | ❌ | Missing files in data/processed/user_logs; Missing files in data/processed/event_logs |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ✅ | |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
… the right place (i.e. fixing Q6)
|
Complete |
|
Great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TITLE: UofT-DSI | Shell - Assignment 1
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I added in shell scripts that created the required folders, moved the data into the raw and processed folders correctly. Removed files containing IP addresses for user privacy, and created an inventory of all of the processed data.
What did you learn from the changes you have made?
I learned a lot about how to fork and create a new branch (and the difference between them), how add files for staging and then commit, and push the changes. I also learned how to add in comments. I learned how to update my code and push the changes to my github repo. I learned how to compare the changes made by a coworker and how to accept/reject them (and include comments).
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
No
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I did not know the shell codes for the various functions that I needed to perform, so I looked them up on the provided resources.
How were these changes tested?
For my own changes, I tested the code. For my co-worker's changes, I saw that while there was a typo (-rf) the corrected version (-rm) likely would have destructively removed the work that had already been done, so I did not try it.
A reference to a related issue in your repository (if applicable)
Checklist