New plugin: wpc_sel_fill#630
Open
elblake wants to merge 1 commit into
Open
Conversation
dgud
reviewed
Apr 23, 2026
| %% Select the rest of the faces enclosed in sharp edges | ||
| wings_sel:update_sel( | ||
| fun (Fs0, #we{vp=_Vtab}=We0) -> | ||
| Edges = get_sharp_edges(Ang*math:pi()/360.0, We0), |
Owner
There was a problem hiding this comment.
Suggested change
| Edges = get_sharp_edges(Ang*math:pi()/360.0, We0), | |
| Edges = get_sharp_edges(Ang*math:pi()/180.0, We0), |
Or was this intentional ?
Collaborator
Author
There was a problem hiding this comment.
Thanks @dgud, I think I forgot to multiply pi, I'll make the change.
| sel_fill_crease_angle_1(Args, #st{selmode=_Mode}=St0, FillOrGrow) -> | ||
| St1=wings_sel_conv:mode(face, St0), | ||
| sel_fill_crease_angle_1(Args, St1, FillOrGrow). | ||
| get_sharp_edges(Ang_0, #we{fs=Fs0}=We) -> |
Owner
There was a problem hiding this comment.
NITPICK: Prefer an empty line before new functions
Suggested change
| get_sharp_edges(Ang_0, #we{fs=Fs0}=We) -> | |
| get_sharp_edges(Ang_0, #we{fs=Fs0}=We) -> |
Implements new selection tools in the "Fill" and "Grow selection" menu. - Smoothing Group Fills all faces enclosed inside hard edges. - Inside Sharp Edges Fills all faces enclosed inside sharp edges set by the inputted angle. - Inside Color Range Fills all adjacent faces with a color within tolerance of the originally selected faces. - Inside Connected Color Edges Fills all color faces that have continuous color values across edges from one face to another. - Inside Unassigned Color Fills adjacent faces that don't have any color assigned. - Inside Unassigned UV Fills adjacent faces that don't have any UV assigned. - Inside Connected UV Edges Fills adjacent faces that have continuous UV values across edges from one face to another. - Same Number of Edges Fills adjacent faces with the same number of edges, if the original selected face has 6 edges, only adjacent faces with 6 edges are selected. - Adjacent Triangles Only fill adjacent triangles. - Adjacent Quads Only fill adjacent quads. - Adjacent NGons Only fill adjacent faces with more than 4 edges. NOTE: Added "Fill" and "Grow selection" commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements new selection tools in the "Fill" and "Grow selection" menu.
Smoothing Group: Fills all faces enclosed inside hard edges.
Inside Sharp Edges: Fills all faces enclosed inside sharp edges set by the inputted angle.
Inside Color Range: Fills all adjacent faces with a color within tolerance of the originally selected faces.
Inside Connected Color Edges: Fills all color faces that have continuous color values across edges from one face to another.
Inside Unassigned Color: Fills adjacent faces that don't have any color assigned.
Inside Unassigned UV: Fills adjacent faces that don't have any UV assigned.
Inside Connected UV Edges: Fills adjacent faces that have continuous UV values across edges from one face to another.
Same Number of Edges: Fills adjacent faces with the same number of edges, if the original selected face has 6 edges, only adjacent faces with 6 edges are selected.
Adjacent Triangles: Only fill adjacent triangles.
Adjacent Quads: Only fill adjacent quads.
Adjacent NGons: Only fill adjacent faces with more than 4 edges.
NOTE: Added "Fill" and "Grow selection" commands.