feat: migrate asset-canister sync to v2.2.0 recipe / plugin step#207
Draft
raymondk wants to merge 2 commits into
Draft
feat: migrate asset-canister sync to v2.2.0 recipe / plugin step#207raymondk wants to merge 2 commits into
raymondk wants to merge 2 commits into
Conversation
icp-cli 1.0.0 removes the built-in `type: assets` sync step (dfinity/icp-cli#582). Asset uploading now lives in a `plugin` (or `script`) sync step; the `@dfinity/asset-canister@v2.2.0` recipe supplies it automatically. Sync plugins are supported since icp-cli 0.2.7, so adopting v2.2.0 now smooths the 1.0 transition. - asset-canister: bump recipe v2.1.0 -> v2.2.0, compatibility -> icp-cli >= 0.2.7, add Pitfall #10 (removed type: assets; use v2.2.0 recipe or manual plugin/script step) - icp-cli: bump recipe refs to v2.2.0 (config block, recipes table, pitfall #10 example, dfx-migration mapping); update sync-phase prose (asset upload no longer built into the CLI) - evals: add adversarial "removed type: assets sync step" case, tighten recipe-setup to require v2.2.0+ (both 4/4 with skill) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Skill Validation ReportProject Checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
dfinity/icp-cli#582 removes the built-in
type: assetssync step in icp-cli 1.0.0. Asset uploading moves out of the CLI core into aplugin(orscript) sync step — the@dfinity/asset-canister@v2.2.0recipe supplies a plugin-based step automatically.Our
asset-canisterandicp-cliskills pinned the recipe at v2.1.0, which generates the now-removedtype: assetsstep and will break on 1.0.0. Sync plugins are supported since icp-cli 0.2.7, so moving to v2.2.0 now (well ahead of 1.0.0) is the smooth migration path.Changes
skills/asset-canister/SKILL.mdcompatibility:→icp-cli >= 0.2.7@dfinity/asset-canister@v2.1.0→v2.2.0type: assetsremoved in 1.0.0 → use the v2.2.0 recipe (auto plugin step), or a manualtype: plugin(certified-assetssync_plugin.wasm+sha256) /type: scriptstep. Recipes ≤ v2.1.0 break on 1.0.0.skills/icp-cli/SKILL.md(+references/dfx-migration.md)type: assetsremoved in 1.0.0evaluations/asset-canister.jsontype: assetsstepEvals
asset-canister output evals (with-skill, --no-baseline)
🤖 Generated with Claude Code