chore: add mise for unified tool versioning#189
Merged
Conversation
Replace the bespoke `taiki-e/install-action` step for cargo-sort and the `cargo install canbench` step with a single `jdx/mise-action` step driven by a new `mise.toml` pinning Rust, cargo-sort, and canbench. Local development uses the same versions via `mise install`, addressing DEFI-2821. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
✅ No security or compliance issues detected. Reviewed everything up to f6a4a78. Security Overview
Detected Code Changes
|
Drop the duplicate `rust = …` pin from `mise.toml` and enable mise's idiomatic-version-file setting so the Rust version is read from `rust-toolchain.toml`. Addresses review feedback on dfinity/evm-rpc-canister#589. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the bespoke
taiki-e/install-actionstep (forcargo-sort) and thecargo install canbenchstep with a singlejdx/mise-actionstep driven by a newmise.tomlpinning Rust 1.93.0, cargo-sort 2.0.1, and canbench 0.4.1. Local development uses the same versions viamise install, so contributors and CI no longer diverge.Follows the pattern used in
dfinity/internet-intelligenceand matches the migration already applied todfinity/crosschain-wallet(#88) anddfinity/evm-rpc-canister(#589). Addresses DEFI-2821.