Refactor BaseMetricService (#17)

[sonnenco]

Issue

#17

Changes

1. Refactored /backend/domain/services/base.py from BaseMetricService class with static methods to standalone functions.

2. Removed import and use of BaseMetricService class from backend/domain/services/abandoned_problems_service.py due to lack of invocation of _deduplicate_problems or _filter_successful_submissions.

3. Updated the import statements and use of BaseMetricService in several files to point to the standalone functions, including:

* backend/domain/services/tags_service.py
* backend/domain/services/difficulty_distribution.py
* backend/domain/services/__init__.py
* backend/tests/unit/base_metric_service/test_deduplicate_problems.py
* backend/tests/unit/base_metric_service/test_filter_successful_submissions.py

Testing

The following tests come out identical to the main branch:

• Backend: linting, type checking, tests
• Frontend: linting, type checking, build

---

Please let me know if there are any questions or concerns.

[deyna256]

You did a great job! But pulling private functions out of the services package seems very strange to me. I have an idea about refactoring the private functions - let's make an abstraction which will encapsulate a bunch of Problem objects. It can have both of our private methods to do some filtering with the Problem objects it has. What do you think?

[sonnenco]

Hello @deyna256 - thank you for the feedback. I can adjust, but would like to confirm my understanding of your proposed solution before I make further changes:

Current

• Private functions declared in base.py
• Private functions are imported for use into other files in the Services package and test suite

Future

• Create a class in base.py that contains both of the non-static methods and initializes attributes for _submissions and _problems
• Methods can access these attributes to perform deduplication and filtering capabilities within the class
• Use the new class in the other files in the Services package and test suite

Please let me know if I've missed anything or misunderstood.

[deyna256]

@sonnenco exactly! let's do it!

[deyna256]

@sonnenco you did a great job! Just fix some issues and we are good to merge it!

[deyna256]

In Python, prefixing a method name with an underscore (_) is a convention used to signal that the method is intended to be private (i.e., not part of the public API). But in our case methods: _deduplicate_problems and _filter_successful_submissions are public API of SubmissionProcessor class, rename them

[deyna256]

Why do we name the class like this? A developer cannot understand its meaning if they don't read its methods, so we should rename it.

[deyna256]

@sonnenco also you need to fix the checks: Backend Tests, Backend Type Checker

[sonnenco]

backend testing

• just test passes required test coverage, very similar results to main branch
• just check states "all checks passed" (runs lint + typecheck)

frontend testing

• just typecheck states "npx tsc --noEmit"
• just lint doesn't come back with anything

Docker container builds fine locally (just build) and is accessible from http://localhost:3000 (just up).

Awaiting validation from workflows to double check results.

[sonnenco]

Thank you for your patience @deyna256. I've addressed the feedback as best I can. Re-requesting review.