fix(admin): serialize audit-log search via PagedModel (0.4.1)#58
Merged
Conversation
GET /admin/api/v1/audit-logs returned a raw PageImpl, which Spring Data 4
warns is not a stable serialization ("Serializing PageImpl instances as-is
is not supported"). Wrap it in PagedModel for a stable
{ content, page: { size, number, totalElements, totalPages } } contract.
Contained to this endpoint — no global @EnableSpringDataWebSupport, so a
consumer's own pagination is unaffected. The admin-ui already consumes this
shape (content + page). Docs/CHANGELOG + install coordinates bumped to 0.4.1.
Full suite green: 54 tests, 0 failures/0 errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /admin/api/v1/audit-logsreturned a rawPageImpl, which Spring Data 4 warns is not a stable serialization:Wrap the result in
PagedModel→ stable{ content, page: { size, number, totalElements, totalPages } }contract, and the warning is gone.@EnableSpringDataWebSupport, so a consumer app's own pagination is unaffected.auditLogs.tshandlescontent+ nestedpage), so no frontend change.Verification
Full suite green locally: 54 tests, 0 failures / 0 errors (
./gradlew build, Testcontainers). No test asserted the old shape.요약 (한국어)
GET /admin/api/v1/audit-logs가 rawPageImpl을 반환해 Spring Data 4 가 "안정적 직렬화가 아니다"라고 경고하던 것을PagedModel로 감싸 안정적 계약({ content, page:{...} })으로 고칩니다. 경고 사라짐.@EnableSpringDataWebSupport없음 → 소비자 앱 자체 페이징 영향 없음.검증: 로컬 전체 그린 54 tests, 0/0.