docs: add Korean READMEs to ssrf-guard demos + Discussions link#11
Merged
Conversation
Bilingual coverage for the 5 ssrf-guard demos (matches the convention the libraries themselves follow — README.md + README.ko.md with a language-picker line at the top). Top-level README also picks up: - Korean translation (README.ko.md) - A pointer to the new Discussions (bilingual maintenance promised) Pattern, per demo: - README.md — primary content, English - README.ko.md — translation, kept in lockstep - Both have a `**English** · [한국어](README.ko.md)` or reverse line up top Follow-up (not in this PR): easy-paging-* demos still English only. Same treatment can be applied — straightforward translation work.
3 tasks
jlc488
added a commit
that referenced
this pull request
May 23, 2026
Bilingual coverage for the 4 easy-paging demos — same convention as the ssrf-guard demos (PR #11) and the libraries themselves: README.md + README.ko.md with a language-picker line at the top. Affected demos: - easy-paging-demo (offset pagination + envelope replacement) - easy-paging-keyset-demo (cursor pagination, size+1 trick, signed cursors) - easy-paging-postgres-demo (real PG via Docker Compose + Testcontainers) - easy-paging-reactive-demo (WebFlux + R2DBC, identical wire contract) All 4 demos now have: - README.md primary English content + `**English** · [한국어](README.ko.md)` - README.ko.md full Korean translation, kept in lockstep with English Closes the gap noted in PR #11 — all 9 demos in this repo are now bilingual. Top-level README + maintenance posts in Discussions already were.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bilingual READMEs for the 5 ssrf-guard demos + the top-level README. Matches the convention the libraries themselves use (
README.md+README.ko.mdwith a language-picker line at the top).Also adds a pointer to the new bilingual Discussions from the top-level README.
Files added (10) / changed (6)
README.mdREADME.ko.mdssrf-guard-demo/README.mdssrf-guard-demo/README.ko.mdssrf-guard-springai-demo/README.mdssrf-guard-springai-demo/README.ko.mdssrf-guard-feign-demo/README.mdssrf-guard-feign-demo/README.ko.mdssrf-guard-jdkhttp-demo/README.mdssrf-guard-jdkhttp-demo/README.ko.mdssrf-guard-okhttp-demo/README.mdssrf-guard-okhttp-demo/README.ko.mdTest plan
build.gradle.ktstouched, so CI matrix should skip every demo build (detect step returns empty)README.ko.mdon GitHub web, confirm tables / fenced code render correctlyFollow-up (not in this PR)
easy-paging-*demos (4 total) are still English-only. Same treatment — language picker line +.ko.mdtranslation — can be applied as its own PR.