Skip to content

docs: add Korean READMEs to ssrf-guard demos + Discussions link#11

Merged
jlc488 merged 1 commit into
mainfrom
ssrf-guard-demos-bilingual
May 23, 2026
Merged

docs: add Korean READMEs to ssrf-guard demos + Discussions link#11
jlc488 merged 1 commit into
mainfrom
ssrf-guard-demos-bilingual

Conversation

@jlc488

@jlc488 jlc488 commented May 23, 2026

Copy link
Copy Markdown
Contributor

Summary

Bilingual READMEs for the 5 ssrf-guard demos + the top-level README. Matches the convention the libraries themselves use (README.md + README.ko.md with a language-picker line at the top).

Also adds a pointer to the new bilingual Discussions from the top-level README.

Files added (10) / changed (6)

Demo Action
Top-level README.md Add language picker + Discussions link
Top-level README.ko.md New
ssrf-guard-demo/README.md Add language picker
ssrf-guard-demo/README.ko.md New (full translation)
ssrf-guard-springai-demo/README.md Add language picker
ssrf-guard-springai-demo/README.ko.md New
ssrf-guard-feign-demo/README.md Add language picker
ssrf-guard-feign-demo/README.ko.md New
ssrf-guard-jdkhttp-demo/README.md Add language picker
ssrf-guard-jdkhttp-demo/README.ko.md New
ssrf-guard-okhttp-demo/README.md Add language picker
ssrf-guard-okhttp-demo/README.ko.md New

Test plan

  • CI: no demo build.gradle.kts touched, so CI matrix should skip every demo build (detect step returns empty)
  • Render check: open each README.ko.md on GitHub web, confirm tables / fenced code render correctly

Follow-up (not in this PR)

easy-paging-* demos (4 total) are still English-only. Same treatment — language picker line + .ko.md translation — can be applied as its own PR.

Bilingual coverage for the 5 ssrf-guard demos (matches the convention
the libraries themselves follow — README.md + README.ko.md with a
language-picker line at the top).

Top-level README also picks up:
  - Korean translation (README.ko.md)
  - A pointer to the new Discussions (bilingual maintenance promised)

Pattern, per demo:
  - README.md     — primary content, English
  - README.ko.md  — translation, kept in lockstep
  - Both have a `**English** · [한국어](README.ko.md)` or reverse line up top

Follow-up (not in this PR): easy-paging-* demos still English only.
Same treatment can be applied — straightforward translation work.
@jlc488
jlc488 merged commit 15384bf into main May 23, 2026
7 checks passed
@jlc488
jlc488 deleted the ssrf-guard-demos-bilingual branch May 23, 2026 06:27
jlc488 added a commit that referenced this pull request May 23, 2026
Bilingual coverage for the 4 easy-paging demos — same convention as the
ssrf-guard demos (PR #11) and the libraries themselves: README.md +
README.ko.md with a language-picker line at the top.

Affected demos:
  - easy-paging-demo         (offset pagination + envelope replacement)
  - easy-paging-keyset-demo  (cursor pagination, size+1 trick, signed cursors)
  - easy-paging-postgres-demo (real PG via Docker Compose + Testcontainers)
  - easy-paging-reactive-demo (WebFlux + R2DBC, identical wire contract)

All 4 demos now have:
  - README.md     primary English content + `**English** · [한국어](README.ko.md)`
  - README.ko.md  full Korean translation, kept in lockstep with English

Closes the gap noted in PR #11 — all 9 demos in this repo are now
bilingual. Top-level README + maintenance posts in Discussions already
were.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant