Skip to content

Do entity start metric update and expiration fiber start asynchronously to reduce contention #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghostdogpr merged 1 commit into from
May 26, 2026
Merged

Do entity start metric update and expiration fiber start asynchronously to reduce contention #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions entities/src/main/scala/com/devsisters/shardcake/internal/EntityManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,23 +163,23 @@ private[shardcake] object EntityManager {
ZIO.fail(EntityNotManagedByThisPod(entityId))
case false =>
// queue doesn't exist, create a new one
for {
queue <- Queue.unbounded[Req]
// start the expiration fiber
expirationFiber <- startExpirationFiber(entityId)
_ <- gauge.increment
_ <- behavior(entityId, queue)
.ensuring(
// shutdown the queue when the fiber ends
entities.update(_ - entityId) *>
gauge.decrement *>
entitiesLastReceivedAt.update(_ - entityId) *>
queue.shutdown *>
expirationFiber.interrupt
)
.forkDaemon
leftQueue = Left(queue)
} yield (leftQueue, map.updated(entityId, leftQueue))
Queue.unbounded[Req].flatMap { queue =>
val leftQueue = Left(queue)
(for {
// start the expiration fiber
expirationFiber <- startExpirationFiber(entityId)
_ <- gauge.increment
_ <- behavior(entityId, queue)
.ensuring(
// shutdown the queue when the fiber ends
entities.update(_ - entityId) *>
gauge.decrement *>
entitiesLastReceivedAt.update(_ - entityId) *>
queue.shutdown *>
expirationFiber.interrupt
)
} yield ()).forkDaemon.as((leftQueue, map.updated(entityId, leftQueue)))
}
}
}
)
Expand Down