Skip to content

#1844: Fix VSCode installation hanging in WSL#1932

Open
satorus wants to merge 2 commits into
devonfw:mainfrom
satorus:feature/1844-set-DONT-PROMT-WSL-INSTALL-env-variable-for-vscode-install-on-wsl
Open

#1844: Fix VSCode installation hanging in WSL#1932
satorus wants to merge 2 commits into
devonfw:mainfrom
satorus:feature/1844-set-DONT-PROMT-WSL-INSTALL-env-variable-for-vscode-install-on-wsl

Conversation

@satorus
Copy link
Copy Markdown
Contributor

@satorus satorus commented May 12, 2026

This PR fixes #1844

Implemented changes:

  • Add detection if we are running in a WSL Linux environment by adding isWSL() method in SystemInfo.java and detection using WSL_DISTRO_NAME and WSL_INTEROP env variables in SytemInfoImpl.java
  • Add env var DONT_PROMPT_WSL_INSTALL=1 when vscode installation (or vscode plugin installation) is happening in a WSL Linux environment. This env variable prevents the yes/no prompt of the command to appear during the installation process.
  • Add test cases for the WSL detection and also for the inclusion of the env variable in the VSCode Commandlet

How to test:

run ideasy install vscode in a WSL Linux environment -> see that plugin installation does not hang at the first plugin (hopefully)


Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

Checklist for tool commandlets

Have you added a new «tool» as commandlet? There are the following additional checks:

  • The tool can be installed automatically (during setup via settings) or via the commandlet call
  • The tool is isolated in its IDEasy project, see Sandbox Principle
  • The new tool is added to the table of tools in LICENSE.asciidoc
  • The new commandlet is a command-wrapper for «tool»
  • Proper help texts for all supported languages are added here
  • The new commandlet installs potential dependencies automatically
  • The variables «TOOL»_VERSION and «TOOL»_EDITION are honored by your commandlet
  • The new commandlet is tested on all platforms it is available for or tested on all platforms that are in scope of the linked issue

@satorus satorus added vscode Microsoft visual studio code linux specific for linux OS (debian, ubunutu, suse, etc.) plugins related to plugins (for Eclipse, Intellij, VSCode, etc.) CLI IDEasy command-line-interface (parsing args, etc.) labels May 12, 2026
@satorus satorus self-assigned this May 12, 2026
@satorus satorus moved this from 🆕 New to Team Review in IDEasy board May 12, 2026
@satorus satorus marked this pull request as ready for review May 12, 2026 13:07
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented May 12, 2026

Coverage Report for CI Build 25736422770

Coverage increased (+0.05%) to 70.677%

Details

  • Coverage increased (+0.05%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 2 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

2 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/os/SystemInfoImpl.java 1 87.76%
com/devonfw/tools/ide/os/SystemInfo.java 1 90.0%

Coverage Stats

Coverage Status
Relevant Lines: 15478
Covered Lines: 11399
Line Coverage: 73.65%
Relevant Branches: 6924
Covered Branches: 4434
Branch Coverage: 64.04%
Branches in Coverage %: Yes
Coverage Strength: 3.12 hits per line

💛 - Coveralls

@satorus satorus changed the title #1844: Fix VSCode installation haning in WSL #1844: Fix VSCode installation hanging in WSL May 12, 2026
@MarvMa MarvMa self-assigned this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLI IDEasy command-line-interface (parsing args, etc.) linux specific for linux OS (debian, ubunutu, suse, etc.) plugins related to plugins (for Eclipse, Intellij, VSCode, etc.) vscode Microsoft visual studio code

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

VSCode plugin installation progress freezing

3 participants