MySQL Management Script, PhpMyAdmin 5.2.3 Update & Maintenance Fixes#15
MySQL Management Script, PhpMyAdmin 5.2.3 Update & Maintenance Fixes#15diskyer wants to merge 6 commits into
Conversation
|
@diskyer Thanks for this, however the Regarding mysql-db-user-manager.sh, can you combine this into |
Hi @nntoan! Thanks for the feedback. I've updated the PR with the following changes:
You can review the latest changes here: 350f01e Looking forward to your thoughts! |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adds small maintenance fixes to the DevilBox web config/theme, including a safer Redis password extraction step and some UI color adjustments (in support of the PhpMyAdmin update/compatibility work referenced in the description).
Changes:
- Adjusted custom CSS to set default text colors for table cells and the page body.
- Refactored Redis password extraction to avoid passing non-variables by reference.
Reviewed changes
Copilot reviewed 2 out of 4662 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .devilbox/www/htdocs/assets/css/custom.css | Updates default text coloring for tables and body. |
| .devilbox/www/config.php | Refactors Redis password parsing to avoid end(end(...)) reference warnings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $_REDIS_PASS_ROW = end($_REDIS_PASS); | ||
| $_REDIS_PASS = end($_REDIS_PASS_ROW); | ||
|
|
There was a problem hiding this comment.
end() requires an array/object passed by reference. If $_REDIS_PASS is empty (or if its last element isn’t an array), end($_REDIS_PASS) can yield false/scalar and end($_REDIS_PASS_ROW) will raise a TypeError on PHP 8+. Add a guard ensuring $_REDIS_PASS_ROW is an array before calling end(), and default to an empty string when the regex doesn’t produce the expected nested array structure (e.g., use array_key_last(...) + indexing with ?? '', or is_array($_REDIS_PASS_ROW) checks).
| $_REDIS_PASS_ROW = end($_REDIS_PASS); | |
| $_REDIS_PASS = end($_REDIS_PASS_ROW); | |
| $_REDIS_PASS_LAST_KEY = array_key_last($_REDIS_PASS); | |
| $_REDIS_PASS_ROW = $_REDIS_PASS_LAST_KEY !== null ? ($_REDIS_PASS[$_REDIS_PASS_LAST_KEY] ?? null) : null; | |
| $_REDIS_PASS = ''; | |
| if (is_array($_REDIS_PASS_ROW)) { | |
| $_REDIS_PASS_ROW_LAST_KEY = array_key_last($_REDIS_PASS_ROW); | |
| $_REDIS_PASS = $_REDIS_PASS_ROW_LAST_KEY !== null ? ($_REDIS_PASS_ROW[$_REDIS_PASS_ROW_LAST_KEY] ?? '') : ''; | |
| } |
| .table-bordered td, .table-bordered th { | ||
| color: #dffce3; | ||
| } |
There was a problem hiding this comment.
Setting very light foreground colors (#dffce3 for table cells and #888888 for body text) without also ensuring an appropriate background can drop contrast below WCAG recommendations, especially on default light backgrounds (e.g., white table backgrounds). Consider selecting colors that meet contrast ratios for normal text, or pair these rules with explicit background colors/variables that guarantee compliant contrast.
| body { | ||
| /* Margin bottom by footer height */ | ||
| margin-bottom: 80px !important; | ||
| color: #888888; |
There was a problem hiding this comment.
Setting very light foreground colors (#dffce3 for table cells and #888888 for body text) without also ensuring an appropriate background can drop contrast below WCAG recommendations, especially on default light backgrounds (e.g., white table backgrounds). Consider selecting colors that meet contrast ratios for normal text, or pair these rules with explicit background colors/variables that guarantee compliant contrast.
| .table-bordered td, .table-bordered th { | ||
| color: #dffce3; | ||
| } |
There was a problem hiding this comment.
Indentation in this file appears to primarily use tabs elsewhere, but this block introduces space-indented lines. Aligning indentation with the surrounding convention will reduce noisy diffs and keep formatting consistent.
MySQL Management Script, PhpMyAdmin 5.2.3 Update (respect PHP 8.4)
Goal
DESCRIPTION
This PR includes the following changes:
1. MySQL Database & User Manager Script (inside
dvl.sh)new
./dvl.sh [command]2. PhpMyAdmin Update (v5.2.1 → v5.2.3)
.devilbox/www/3. Gitignore Improvements (
.gitignore)docker-compose.override*.dockerfile.zed,.obsidian