lopper:assist:baremetal_validate_comp_xlnx: Fix srec_spi_bootloader b…#762
Merged
Merged
Conversation
…uild failure on Spartan US+ OSPI-enabled design The baremetal_validate_comp_xlnx assist previously issued a hard validation error when the xilsfl dependency (introduced via srec_spi_bootloader) could not be resolved on MicroBlaze and MicroBlaze RISC-V targets that are not Spartan UltraScale+, even though xilsfl is intentionally unsupported on these platforms, resulting in unnecessary build failures this change introduces an optional fourth argument (parent_app) to enable application-aware validation without impacting existing call sites, enhances platform detection by extracting family and variant from the SDT root node, and updates the validation logic to suppress the xilsfl error and emit a warning only when the parent application is srec_spi_bootloader running on non-Spartan UltraScale+ MicroBlaze or MicroBlaze RISC-V targets, while preserving the existing error behavior for all other platforms and application Signed-off-by: Sathish Kumar Kamishettigari <sathishkumar.kamishettigari@amd.com>
Contributor
Author
|
Hi @onkarharsh, Please review this |
Contributor
|
Looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…uild failure on Spartan US+ OSPI-enabled design
The baremetal_validate_comp_xlnx assist previously issued a hard validation error when the xilsfl dependency (introduced via srec_spi_bootloader) could not be resolved on MicroBlaze and MicroBlaze RISC-V targets that are not Spartan UltraScale+, even though xilsfl is intentionally unsupported on these platforms, resulting in unnecessary build failures this change introduces an optional fourth argument (parent_app) to enable application-aware validation without impacting existing call sites, enhances platform detection by extracting family and variant from the SDT root node, and updates the validation logic to suppress the xilsfl error and emit a warning only when the parent application is srec_spi_bootloader running on non-Spartan UltraScale+ MicroBlaze or MicroBlaze RISC-V targets, while preserving the existing error behavior for all other platforms and application