refactor: centralize async runtime around shared loop and pools#61
Open
hrodmn wants to merge 7 commits into
Open
refactor: centralize async runtime around shared loop and pools#61hrodmn wants to merge 7 commits into
hrodmn wants to merge 7 commits into
Conversation
cbef616 to
1faee9d
Compare
835441f to
7527567
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The concurrency model was somewhat messy (as noted in #31) so I wanted to make things simpler. Here are a few refactor-ish changes that make lazycogs concurrency easier to reason about:
The single reprojection pool affected the benchmark conditions for the single-worker case so we see a regression in that benchmark test.
I also removed the not-very-useful
read_chunksynchronous shim aroundread_chunk_async.