chore: replace ObjectStore type requirement with ObspecInput#60
Conversation
Benchmark Comparison
|
|
|
||
| ## Custom store contract | ||
|
|
||
| When you pass `store=` explicitly, lazycogs forwards that object to `async-geotiff`. The object does not need to be an obstore `ObjectStore`; it only needs to satisfy the obspec-compatible async range-read contract accepted by `GeoTIFF.open()`. |
There was a problem hiding this comment.
I think a link here would be good. You can link to https://developmentseed.org/async-geotiff/latest/api/geotiff/#async_geotiff.GeoTIFF.open, and then potentially also to the ObspecInput type
| if TYPE_CHECKING: | ||
| from collections.abc import Callable | ||
|
|
||
| from async_tiff import ObspecInput |
There was a problem hiding this comment.
Hmm, perhaps we should re-export ObspecInput through the async-geotiff API too? 🤷♂️
I don't really like the name ObspecInput either. I think just Store would be more descriptive. Any thoughts?
There was a problem hiding this comment.
It seems a little odd to be importing from async-tiff but it was already an indirect dependency so it's not a big deal.
Store would be a more intuitive name. ObspecInput says a lot about what the class is but not very much about what it does.
There was a problem hiding this comment.
developmentseed/async-geotiff#161
With 0.5.1 you should be able to use the Store protocol defined in async-geotiff
resolves #28