ci: gate PRs on the dashboard Vitest suite

[ivndev001]

What

Add a dedicated frontend (vitest) CI job so the dashboard's existing Vitest suite gates PRs. Closes #273.

Why

frontend/package.json defines test: vitest run with 4 committed suites (25 tests), but no workflow runs them — CI only builds the SPA via rake frontend:build (tsc + vite). tsc can typecheck clean while the app null-renders at runtime (exactly how #272's /dead white-screen shipped), so the build step is not a regression gate. Frontend regressions currently merge unblocked.

Changes

• .github/workflows/test.yml: new frontend (vitest) job, sibling to test / parity / coverage. Node-only (no Ruby/Redis): blacksmith-4vcpu-ubuntu-2404, timeout-minutes: 10, pinned actions/setup-node@v6 (node 24, npm cache on frontend/package-lock.json), npm ci + npm run test in frontend/. Inherits the workflow-level concurrency group and contents: read permissions.

Notes / decisions

• Runs unconditionally (no frontend/** path filter). A path-filtered required check hangs "Expected — waiting for status" on backend-only PRs and blocks merge forever (a known GitHub trap). The job is ~2s and the existing test job already runs the full node/vite toolchain on every PR, so an always-on run is consistent and negligible. Deliberate deviation from the issue's "gated on frontend/**" wording.
• No new tests in this PR. The /dead null-error_class regression test is red on current main (it only goes green once Dashboard /dead (and /search) white-screens on dead jobs with null error_class/error_message (kill/migration path) #272's truncate guard + serializer normalize land), so adding it here would block the gate. It rides with Dashboard /dead (and /search) white-screens on dead jobs with null error_class/error_message (kill/migration path) #272 as one atomic red->green change. The CI never runs the frontend vitest suite (no gate on dashboard JS regressions) #273 acceptance criterion "the /dead null case is covered by a test that runs in CI" closes jointly: this PR builds the gate, Dashboard /dead (and /search) white-screens on dead jobs with null error_class/error_message (kill/migration path) #272 delivers the test the gate runs.

Verification

• Frontend suite locally on this branch: cd frontend && npm ci && npm run test -> 4 files / 25 tests pass (~2.3s, node 24).
• Workflow YAML is not gated by the repo's Ruby suite, so verified manually: actionlint .github/workflows/test.yml reports only the pre-existing blacksmith-4vcpu-ubuntu-2404 unknown-label warning (identical on the existing test/parity/coverage jobs — actionlint doesn't know Blacksmith's custom runner label; it resolves on the real runner). No other findings. Additive change — existing Ruby gates and the required test (x, y) contexts are unaffected.

Post-merge (admin, ordering-sensitive)

After the frontend (vitest) job reports green once, add frontend (vitest) to main branch-protection required status checks. Do NOT register it before it has reported at least once, or open PRs will hang on a phantom required check.

Summary by CodeRabbit

• Tests
  • Added automated frontend test coverage on pull requests to help catch dashboard regressions earlier.

[coderabbitai]

Caution

Review failed

An error occurred during the review process. Please try again later.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 972876a7-f2e7-4bf4-b138-37483c6321b4

📥 Commits

Reviewing files that changed from the base of the PR and between 206a307 and e660f02.

📒 Files selected for processing (1)

• .github/workflows/test.yml

---

📝 Walkthrough

Walkthrough

The PR adds a frontend job to .github/workflows/test.yml. It checks out the repo, sets up Node 24 with npm caching from frontend/package-lock.json, installs dependencies in frontend/, and runs npm run test for the dashboard Vitest suite.

Changes

Frontend Vitest CI job

Layer / File(s)	Summary
Frontend Vitest job .github/workflows/test.yml	Adds a Node 24 frontend CI job that runs npm ci and npm run test in frontend/, with npm caching keyed to frontend/package-lock.json; nearby comments clarify that the existing matrix jobs only build the SPA.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The new workflow adds the Vitest CI gate, but it does not add the required /dead null-error regression test from #273.	Add the /dead null-error regression test so the frontend regression also runs and passes in CI.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly states the PR gates PRs on the dashboard Vitest suite, matching the main CI change.
Out of Scope Changes check	✅ Passed	The change stays focused on CI for the frontend Vitest suite and does not introduce unrelated code changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

📊 Benchmark vs base

benchmark	base (i/s)	head (i/s)	Δ
wurk enqueue	27.57k	26.53k	-3.8%	🟡 slower (within noise)
wurk fetch+execute	7.08k	7.73k	+9.2%	🟢
wurk hot-path (jobs/1k-alloc)	5	5	+0.0%	🟢
wurk idle scheduler sweep	18.58k	19.05k	+2.5%	🟢
wurk push_bulk(1000)	239	259	+8.7%	🟢
wurk swarm boot	159	160	+0.6%	🟢

Regression is flagged when the slowdown exceeds both runs' combined ± noise plus 5.0% (tune via BENCH_REGRESSION_PCT).

[ivndev001]

@coderabbitai full review

[coderabbitai]

✅ Action performed

Full review finished.

[dinndev2]

@coderabbitai approve

[coderabbitai]

✅ Action performed

Comments resolved and changes approved.