ci: migrate deploy-prod Flux diagnostics to shared diagnose-flux composite#2317
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe inline Bash diagnostic step in Flux Diagnostics Extraction
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
🎉 This PR is included in version 1.84.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What
Replace the inline
🩺 Diagnose Flux on failurestep in.github/actions/deploy-prod/action.yml(the prod-deploy reconcile failure path) with the shared compositedevantler-tech/actions/diagnose-flux@e182f2207fb386ef827f48b3cc9b7deac873046a # v7.1.0.This is the fourth and final callsite of the
Diagnose Flux on failureblock that devantler-tech/actions#367 set out to consolidate. The three platform-template copies were already migrated in platform-template#46 (merged 2026-06-27); this PR completes the sweep.Why it is safe
if: failure() && steps.reconcile.outcome == 'failure'and only dumps Flux/cluster state withset +e. It cannot influence a successful deploy — the only observable change is which diagnostics print when a deploy has already failed.kustomizationsinput defaults toinfrastructure-controllers infrastructure apps— byte-identical to the list this callsite previously hard-coded — so nowith:override is needed.--tailvalues (300/300/200/80/100 vs the old 200/200/100/60/50) — exactly when good diagnostics matter most, on a failed real prod deploy.e182f22…, v7.1.0) the platform-template callsites use, keeping all four byte-consistent — the whole point of Setup Grafana #367.Validation
yqparse of the editedaction.ymlconfirms the step is a well-formed compositeuses:step (name/if/usesonly; no strayrun/shell/env).Fixes devantler-tech/actions#367
Summary by CodeRabbit