feat: activate RepositoryPermissions MRD for actions SHA-pinning policy#2250
Merged
Merged
Conversation
Activate repositorypermissions.actions.github.m.upbound.io in the github-config MRAP so the org's "Require actions to be pinned to a full-length commit SHA" policy can be reconciled declaratively from devantler-tech/.github deploy/actions-permissions/. The github-config tenant Role already grants the actions.github.m.upbound.io group, so no RBAC change is needed. Gated on a provider-upjet-github release embedding terraform-provider-github >= 6.11.0 (sha_pinning_required); absent in the deployed v0.19.1 (TF 6.6.0). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 1.77.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Activates
repositorypermissions.actions.github.m.upbound.ioin thegithub-configManagedResourceActivationPolicy, so the org's per-repoRequire actions to be pinned to a full-length commit SHA policy
(
sha_pinning_required) can be reconciled declaratively.Why
provider-upjet-githubdeclares SafeStart — its Actions managed resources shipInactive; only those named in the MRAP become CRDs. The companion
devantler-tech/.githubchange (deploy/actions-permissions/) declares aRepositoryPermissionsper managed repo assertingshaPinningRequired: true;those need this MRD active to reconcile.
The
github-configtenant Role already grants theactions.github.m.upbound.ioAPI group, so no RBAC change is needed.
Gating
sha_pinning_requiredis absent from the deployed provider v0.19.1 (pinsterraform-provider-github 6.6.0); it landed in the TF provider in v6.11.0 and is
unavailable until a provider release embedding ≥ 6.11.0 is pinned here. Tracked
by crossplane-contrib/provider-upjet-github#288.
Validation
kubectl kustomize k8s/providers/hetzner/infrastructure/crossplanebuilds; theMRAP
activatelist now includesrepositorypermissions.actions.github.m.upbound.io.Companion
devantler-tech/.github#67 —
deploy/actions-permissions/(theRepositoryPermissionsresources).🤖 Generated with Claude Code