fix: gate repository-permissions/ until provider-upjet-github supports shaPinningRequired#86
Conversation
…s shaPinningRequired Fixes #67's shaPinningRequired patch is applied to every RepositoryPermissions resource, but the field is absent from the deployed provider-upjet-github v0.19.1 CRD schema (it embeds terraform-provider-github 6.6.0; the field landed in 6.11.0). Dry-run rejects the patch, so the prod tenant's `apps` Kustomization health-check times out after 20m every reconcile cycle, stalling deploys and kicking merge-queue PRs out. Unwire repository-permissions/ from the root kustomization until the provider bump (own upstream PR crossplane-contrib/provider-upjet-github#288) lands. 🤖 Generated by the Daily AI Assistant
📝 WalkthroughWalkthroughThis change modifies Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@deploy/kustomization.yaml`:
- Around line 25-37: The gate rationale is duplicated between the top-level
kustomization and the repository-permissions kustomization header, so update
both together to avoid drift. Keep the precondition/tracking note in one
canonical place or remove the duplicate once the provider bump lands, and make
sure any change to the gate in deploy/kustomization.yaml is mirrored in
repository-permissions/kustomization.yaml.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: b1ad6e5a-afaf-44d9-a879-7e71e94c821b
📒 Files selected for processing (1)
deploy/kustomization.yaml
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
- GitHub Check: Analyze (actions)
🧰 Additional context used
📓 Path-based instructions (1)
deploy/**/*.{yaml,yml}
📄 CodeRabbit inference engine (AGENTS.md)
deploy/**/*.{yaml,yml}: Manage GitHub declaratively — never imperatively. Org/repo/team/label configuration must be changed only by editingdeploy/and shipping a PR; do not usegh apiwrites or the GitHub UI to change managed config.
Ownership must be modeled as a team, not an individual. Use themaintainersteam viaTeam/TeamRepository; never grant access or ownership to individual logins.
When adopting an existing live resource, use observe-first settings: setcrossplane.io/external-nameto the live name and use a management policy that excludesDeletefor newRepository/IssueLabels/team resources.
Files:
deploy/kustomization.yaml
🔇 Additional comments (1)
deploy/kustomization.yaml (1)
25-37: LGTM!
CodeRabbit: the precondition/tracking note was fully restated in both deploy/kustomization.yaml and repository-permissions/kustomization.yaml. Point to the latter as the canonical source instead of duplicating it. 🤖 Generated by the Daily AI Assistant
Why
#67's
shaPinningRequiredpatch is currently stalling every prod deploy: the field isn't in the deployed Crossplane provider's CRD schema yet, so the tenant'sappsKustomization health-check times out after 20 minutes on every reconcile cycle — blocking prod deploys and kicking PRs out of the platform merge queue.What
Comments out
repository-permissions/from the root kustomization until the provider bump lands. The directory and its own gate-note stay in place for when that's ready — nothing is deleted, only un-wired from the published artifact.Notes
provider-upjet-githubv0.19.1 embeds terraform-provider-github 6.6.0;sha_pinning_requiredlanded upstream in 6.11.0.kubectl kustomize deploy/ > /dev/nullvalidated clean.Fixes the live prod stall (hit 2026-07-09, ~4h after #67's v1.12.0 publish).