refactor(github): one team resource per file in deploy/teams/#71
Merged
Conversation
Per the maintainer's one-resource-per-file preference: split the 13-resource deploy/teams/maintainers.yaml (Team + TeamMembership + 11 TeamRepository) into one file per resource (filename = resource name, matching ../repositories/). The directory-level explanation moves to teams/kustomization.yaml. Behaviour-preserving: the rendered set of 13 team resources is byte-identical before/after the split (verified via kustomize build diff). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…enames deploy/teams/ mixed three kinds (Team, TeamMembership, TeamRepository) under ambiguous maintainers-<x> names. Split into one subfolder per CR kind, each with an active-verb filename pattern so a file's purpose is clear and files in a folder share one convention: - teams/ — Team (maintainers.yaml) - team-memberships/ — TeamMembership (add-<user>-to-<team>.yaml) - team-repositories/— TeamRepository (grant-<team>-on-<repo>.yaml) Pure rename + kustomization re-wiring; resource bodies (incl. metadata.name and crossplane.io/external-name) are unchanged, so there is no Crossplane resource churn. `kubectl kustomize deploy/` validated (1 Team, 1 TeamMembership, 11 TeamRepository). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![botantler-1[bot]](https://avatars.githubusercontent.com/in/1025824?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the one-resource-per-file convention to the last multi-doc file in
deploy/:deploy/teams/maintainers.yamlheld 13 resources (theTeam, itsTeamMembership, and 11TeamRepositorygrants). Split into one file per resource(filename = resource name, matching
deploy/repositories/); the directory-levelexplanation moves to
deploy/teams/kustomization.yaml.Behaviour-preserving — pure file reorganisation, no resource changed: the rendered
set of 13 team resources is byte-identical before/after (verified via a
kubectl kustomize deploy/diff), and every resource passeskubectl apply --dry-run=serveragainst the live CRDs.Companion to #70 (which applies the same convention to
deploy/rulesets/); togetherthey make every file in
deploy/one resource.