feat(deploy): own the GitHub App credential ExternalSecret + ProviderConfig#41
Merged
Merged
Conversation
…Config Move the tenant-specific auth wiring into this repo's deploy/ artifact (applied by the github-config app's own ServiceAccount on the platform), so the platform only provisions the namespaced SecretStore + RBAC: - external-secret.yaml: github-app-credentials, read via the platform-provided NAMESPACED SecretStore 'openbao' (dedicated github-config Vault role scoped to infrastructure/github/* only — not the shared cluster store) - provider-config.yaml: the namespaced github.m.upbound.io ProviderConfig namespace is omitted; the platform tenant Kustomization injects it via targetNamespace (github-config), like the Repository MRs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![botantler-1[bot]](https://avatars.githubusercontent.com/in/1025824?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the tenant-specific GitHub auth wiring out of the platform repo and into this repo's
deploy/artifact, so the platform only provisions generic scaffolding (namespace, SA, RBAC, and a namespaced SecretStore). Pairs with platform #2039.deploy/external-secret.yaml— thegithub-app-credentialsExternalSecret, now reading through the platform-provisioned namespaced SecretStoreopenbao(a dedicatedgithub-configVault role scoped tosecret/data/infrastructure/github/*only — not the broad cluster-scoped store).deploy/provider-config.yaml— the namespacedgithub.m.upbound.ioProviderConfig.namespaceis omitted on both; the platform tenant Kustomization injectsgithub-configviatargetNamespace(same as the Repository MRs). Applied by the app's own ServiceAccount, whose Role was extended (platform side) with verbs onexternal-secrets.io+github.m.upbound.io.Why
Two maintainer asks: (1) these manifests are tenant-specific, not platform-specific, so they belong here; (2) the tenant should use a namespace-scoped SecretStore — read access to the cluster SecretStore (which can reach every infra + app path) was too broad a privilege. This mirrors the wedding-app tenant pattern.
Rollout
Merge + tag a new
v*release so the publishedgithub-configartifact includes these, alongside platform #2039. Until the maintainer overwrites the OpenBao placeholders atsecret/infrastructure/github/app, the credential is non-working and the provider's auth simply fails (isolated to the leaf apps layer).🤖 Generated with Claude Code