Fix buffer overflow in resolve_full_path#997
Open
buzz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
resolve_full_path()function insrc/harness/os/linux.candsrc/harness/os/macos.cuses a static buffer_program_name[1024], but callsgetcwd(path, PATH_MAX)wherePATH_MAXis 4096 on Linux. This causesgetcwd()to write up to 4096 bytes into a 1024-byte buffer, triggering a stack buffer overflow.The crash is detected by glibc's
_FORTIFY_SOURCE=3protection.