Skip to content

Remove unit tests and Unity test framework#901

Open
jeff-1amstudios wants to merge 32 commits into
dethrace-labs:mainfrom
jeff-1amstudios:remove-unit-tests-and-framework
Open

Remove unit tests and Unity test framework#901
jeff-1amstudios wants to merge 32 commits into
dethrace-labs:mainfrom
jeff-1amstudios:remove-unit-tests-and-framework

Conversation

@jeff-1amstudios

@jeff-1amstudios jeff-1amstudios commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove the entire test/ directory
  • remove Unity test framework sources and test harness files
  • remove root CMake test wiring (BUILD_TESTS option and add_subdirectory(test))

Notes

  • this PR fully removes unit test infrastructure from the repository

@madebr

madebr commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

Do we still need the null platform then?

@jeff-1amstudios
jeff-1amstudios force-pushed the remove-unit-tests-and-framework branch from 155ee48 to f08480d Compare April 10, 2026 20:10
dethrace-labs added a commit that referenced this pull request Apr 10, 2026
@dethrace-labs
Disable werror in builds
c474f59 
Before #901, we weren't building properly with warnings-as-errors. Now we are, we have warnings for uninitialized things
@dethrace-labs dethrace-labs mentioned this pull request Apr 10, 2026
Closed
madebr and others added 20 commits June 30, 2026 14:40
@madebr
Merge branch 'main' into remove-unit-tests-and-framework
57f45e8
@madebr
Merge branch 'main' into remove-unit-tests-and-framework
4e30d9e
@madebr
Add DETHRACE_DEFAULT_BREAK
44c3193
@madebr
fixes
e91c283
@madebr
Fix -Wsometimes-uninitialized warning
6d404df
@madebr
Use identical indentation for DETHRACE_DEFAULT_BREAK
38f79dc
@madebr
Fix -Warray-bounds warning warning
c24f84f
@madebr
Fix -Warray-bounds warning warning
9796594
@madebr
Fix -Warray-bounds warning warning
3ee651c
@madebr
Fix -Wpointer-sign warning
997e197
@madebr
Ignore Wformat-overflow
6696c44
@madebr
Fix -Wmaybe-uninitialized warning
349481d
@madebr
Fix -Wmaybe-uninitialized warning (nodes_referenced_by_sections_array…
2b8c232 
… and sections_referenced_by_nodes_array might be reference uninitialized)
@madebr
Fix -Wmaybe-uninitialized warning (nodes_referenced_by_sections_array…
3edb7bb 
… and sections_referenced_by_nodes_array might be reference uninitialized)
@madebr
Fix -Wmaybe-uninitialized warning (nodes_referenced_by_sections_array…
bfedf52 
… and sections_referenced_by_nodes_array might be reference uninitialized)
@madebr
Fix -Wmaybe-uninitialized warning
2c090dc
@madebr
Fix -Wmaybe-uninitialized warning
2870505
@madebr
Fix -Wmaybe-uninitialized warning
357b8d3
@madebr
Fix -Wmaybe-uninitialized warning
10db63c
@madebr
Fix -Wmaybe-uninitialized warning
cabbbfc
@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown

reccmp report


Saved diff report generated June 30 2026, 16:36:22 (5:08:34 ago)

Increased (50):
0x405f97 - RecordNextTrailNode (96.32% -> 97.99%)
0x407d1e - CalcReturnToStartPointRoute (95.88% -> 100.00%*)
0x409ff7 - TeleportCopToStart (96.12% -> 100.00%*)
0x411947 - CopStartPointInfo (95.83% -> 100.00%)
0x42c171 - ScanCarsPositions (97.35% -> 100.00%)
0x432865 - CalcPlayerScores (91.14% -> 91.29%)
0x435014 - AddPixelmapToStorage (89.04% -> 100.00%)
0x437e2f - AddProximities (98.08% -> 100.00%)
0x4392c4 - MungeMaterial (76.92% -> 100.00%)
0x43f3c3 - LollipopizeActor (91.63% -> 100.00%*)
0x43f744 - PointOutOfSight (77.66% -> 78.72%)
0x4432be - FindSpecialVolume (90.27% -> 95.58%)
0x443465 - DistanceFromFace (89.29% -> 100.00%)
0x4452b1 - BuildSpecVolModel (96.43% -> 100.00%)
0x446ca1 - NetPlayersChanged (89.93% -> 100.00%*)
0x44d2d8 - NextPratcamChunk (71.34% -> 72.17%)
0x44e0dd - DisposePratcam (74.13% -> 79.72%)
0x453ba4 - CheckPlayersAreResponding (88.00% -> 100.00%)
0x45ee73 - WriteOutPeds (95.85% -> 100.00%)
0x4734aa - KillCursor (82.35% -> 100.00%)
0x477d38 - FinishCars (96.03% -> 97.96%)
0x4794d3 - TestAutoSpecialVolume (92.36% -> 96.43%)
0x47a7b1 - ControlCar5 (94.31% -> 100.00%)
0x47b2fd - RotateCar (95.35% -> 100.00%)
0x47b68d - NonCarCalcForce (95.02% -> 100.00%)
0x47ba5d - CalcForce (45.73% -> 46.05%)
0x47ec63 - AddDrag (93.28% -> 100.00%)
0x47f5d0 - CollCheck (68.54% -> 70.15%)
0x481cb9 - AddFriction (84.03% -> 85.30%)
0x483425 - ThreePointCollRec (97.21% -> 100.00%)
0x488849 - MoveCamToIncident (67.82% -> 68.09%)
0x488d45 - PanningExternalCamera (96.23% -> 100.00%*)
0x489553 - NormalPositionExternalCamera (61.51% -> 61.76%)
0x489f7c - SwingCamera (43.29% -> 43.52%)
0x48abbb - CollideCamera2 (47.03% -> 49.32%)
0x48bca8 - FlyCar (77.73% -> 78.58%)
0x492cdd - FourPointCollB (98.33% -> 100.00%)
0x493087 - SetCarSuspGiveAndHeight (97.01% -> 100.00%)
0x49327e - TestForCarInSensiblePlace (92.31% -> 93.33%)
0x49396a - DoPullActorFromWorld (94.39% -> 97.96%)
0x493c46 - CheckForDeAttachmentOfNonCars (95.06% -> 98.35%)
0x4a00a4 - FollowCheatyPath (76.40% -> 76.74%)
0x4a291d - GetPowerup (94.44% -> 100.00%)
0x4a9dc1 - LollipopizeActor4 (90.16% -> 93.44%)
0x4b31bb - BuildColourTable (92.22% -> 100.00%)
0x4b59ce - RenderAFrame (81.19% -> 81.39%)
0x4b7dd1 - DRPixelmapRectangleMaskedCopy (94.71% -> 97.36%)
0x4b89b4 - DoMouseCursor (97.79% -> 99.69%)
0x4bd8da - CrushModel (95.76% -> 100.00%)
0x4be97b - DoPratcamHit (90.11% -> 94.51%)

Decreased (62):
0x403ad9 - RematerialiseOpponent (99.56% -> 99.13%)
0x404b9b - LoadInOppoPaths (98.15% -> 94.00%)
0x409cd5 - HeadOnWithPlayerPossible (96.00% -> 92.00%)
0x40bbc3 - GetOpponentsSectionFinishNodePoint (100.00% -> 91.04%)
0x40cf4e - CalcNegativeXVector (94.50% -> 88.99%)
0x40f331 - FindNearestPathNode (94.52% -> 79.45%)
0x41020c - DropNodeOnNodeAndStopElasticating (94.17% -> 83.64%)
0x4105c6 - RecalcNearestPathSectionSpeed (100.00%* -> 96.97%)
0x4174a9 - DamageScrnDown (98.61% -> 92.68%)
0x417e27 - PrepareBoundingRadius__racesumm (100.00% -> 92.00%)
0x41b925 - PollActionReplayControls (91.99% -> 91.39%)
0x41e5d0 - ReadNonCarMechanicsData (100.00% -> 96.57%)
0x41edfb - ReadMechanicsData (98.22% -> 97.33%)
0x420144 - LoadCar (98.63% -> 98.33%)
0x4233d3 - LoadHeadups (100.00% -> 73.16%)
0x433676 - SelectRandomItOrFox (80.26% -> 75.00%)
0x4344f4 - GetExpandedMatrix (100.00% -> 97.47%)
0x4351fa - AddMaterialToStorage (89.74% -> 85.90%)
0x436b8b - AddFunkotronics (96.69% -> 96.27%)
0x4396ce - RevealStoredTransparentTextures (100.00% -> 79.66%)
0x439784 - HideStoredTextures (100.00% -> 57.81%)
0x452077 - DrawGrid (81.85% -> 78.65%)
0x4568d7 - MungePedestrianFrames (98.51% -> 98.01%)
0x459db7 - MungePedestrianAction (100.00%* -> 92.38%)
0x45a3bd - CheckPedestrianDeathScenario (97.58% -> 97.31%)
0x45bcc5 - MoveToEdgeOfCar (94.18% -> 93.47%)
0x45c921 - RespawnPedestrians (100.00% -> 96.83%)
0x465090 - MungeEngineNoise (100.00% -> 98.67%)
0x465719 - DRS3StartCDA (100.00% -> 85.51%)
0x4707bd - MungeHeadups (100.00% -> 98.34%)
0x475d7d - SetInitialPosition (97.12% -> 95.83%)
0x4764ca - GetFacesInBox (98.36% -> 97.75%)
0x47839b - ApplyPhysicsToCars (97.63% -> 96.15%)
0x479c6d - ControlCar2 (100.00% -> 95.58%)
0x479f4b - ControlCar3 (100.00% -> 95.40%)
0x483e92 - FindFloorInBoxBU2 (100.00%* -> 97.10%)
0x48469b - AddEdgeCollPoints (50.26% -> 49.83%)
0x485bea - oldMoveOurCar (83.04% -> 82.14%)
0x487b89 - IncidentCam (63.80% -> 60.25%)
0x488f50 - SetUpPanningCamera (92.46% -> 91.97%)
0x48a73b - PointCameraAtCar (61.30% -> 60.78%)
0x48c8af - CrashCarsTogetherSinglePass (55.90% -> 54.28%)
0x48d84a - CollideTwoCars (100.00% -> 99.00%)
0x48f686 - FacePointCarCarCollide (48.79% -> 46.81%)
0x48fd16 - DoCollide (94.88% -> 94.67%)
0x49231c - AddFrictionCarToCar (95.24% -> 94.18%)
0x49e3a0 - ProcessFollowPath (57.12% -> 57.06%)
0x4a1ec9 - CheckRecoveryOfCars (100.00% -> 92.52%)
0x4a234a - FlipUpCar (98.77% -> 98.03%)
0x4a90ff - FindNonCarsCB (90.18% -> 88.98%)
0x4b400e - DistanceFromPlane (82.35% -> 79.41%)
0x4b553b - MungeClipPlane (93.20% -> 91.18%)
0x4b81e6 - DRPixelmapRectangleShearedCopy (61.64% -> 59.05%)
0x4bdbc1 - TotallySpamTheModel (80.83% -> 75.00%)
0x4bde6c - RepairModel (100.00% -> 94.76%)
0x4beaa3 - DamageSystems (98.55% -> 97.26%)
0x4bfdb3 - DoCrashEarnings (98.27% -> 97.77%)
0x4c3149 - NormalSideOfPlane (100.00% -> 88.24%)
0x52d140 - __OP_FMODjmptab (32.18% -> 21.33%)
0x52d4b0 - __OP_SQRTjmptab (56.00% -> 51.85%)
0x52d6a2 - __OP_SINjmptab (51.43% -> 50.00%)
0x52d6c2 - __OP_COSjmptab (48.48% -> 46.67%)

Compiler entropy (32):
0x40fdf3 - InsertAndDontElasticate (100.00%* -> 100.00%)
0x42434a - SkipRestOfRace (100.00%* -> 100.00%)
0x433c0e - UseGeneralScore (100.00%* -> 100.00%)
0x4357fc - LoadNShadeTables (100.00%* -> 100.00%)
0x435a92 - LoadNMaterials (100.00%* -> 100.00%)
0x435c60 - LoadNModels (100.00% -> 100.00%*)
0x448695 - ReceivedGuaranteeReply (100.00% -> 100.00%*)
0x449f18 - PlayerIsInList (100.00%* -> 100.00%)
0x45140b - SuggestRace (100.00% -> 100.00%*)
0x45a078 - CalcPedestrianDangerLevel (100.00%* -> 100.00%)
0x463a93 - SetSkyTextureOn (100.00%* -> 100.00%)
0x464b51 - InitSoundSources (100.00% -> 100.00%*)
0x472766 - RollLettersIn (100.00%* -> 100.00%)
0x472dca - RevertTyping (100.00%* -> 100.00%)
0x472fb9 - DoRLBackspace (100.00%* -> 100.00%)
0x475027 - ChoiceDisabled (100.00%* -> 100.00%)
0x4771a2 - RememberSafePosition (100.00% -> 100.00%*)
0x478928 - InterpolateCars (100.00% -> 100.00%*)
0x478b58 - GetNonCars (100.00%* -> 100.00%)
0x47b23c - SimpleRotate (100.00%* -> 100.00%)
0x47ede9 - DoBumpiness (100.00%* -> 100.00%)
0x4825a8 - CrushAndDamageCar (100.00% -> 100.00%*)
0x483a49 - MultiFindFloorInBoxM (100.00%* -> 100.00%)
0x48d38c - CollideTwoCarsWithWalls (100.00% -> 100.00%*)
0x496902 - DoDeltaTrans (100.00%* -> 100.00%)
0x497edd - ServicePanelFlics (100.00% -> 100.00%*)
0x4a9a01 - DrawColumns (100.00% -> 100.00%*)
0x4b1297 - DisposeJoinList (100.00%* -> 100.00%)
0x4b1bfd - DrawNetOptBox (100.00%* -> 100.00%)
0x4b1f93 - DrawNetChoose (100.00% -> 100.00%*)
0x4b3180 - DrawDigitAt (100.00%* -> 100.00%)
0x4c2b84 - GenerateDarkenedShadeTable (100.00%* -> 100.00%)


Total effective accuracy 96.42% across 2387 functions (96.08% actual accuracy)
13 functions are aligned (0.54%)

@madebr

madebr commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

@jeff-1amstudios I fixed the fatal dethrace warnings. Can you have a another look at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeff-1amstudios @madebr