Skip to content

Multiplayer big endian fix #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BSzili wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Multiplayer big endian fix #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c9c856
Multiplayer big endian fix
BSzili Oct 18, 2025
75a5db6
Separate the network byteswap functions into network_endian.h
BSzili Jan 6, 2026
9e9b6cb
Don't include network_endian.h if BR_ENDIAN_BIG is not 1
BSzili Jan 6, 2026
4af9cba
Fix the BR_ENDIAN_BIG macro guard in network_endian.h
BSzili Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/DETHRACE/common/network.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include "structur.h"
#include "utility.h"
#include "world.h"
#include "network_endian.h"
#include <stdlib.h>

tU32 gMess_max_flags;
Expand Down Expand Up @@ -820,6 +821,9 @@ int NetSendMessageToAddress(tNet_game_details* pDetails, tNet_message* pMessage,
}
pMessage->sender = gLocal_net_ID;
pMessage->senders_time_stamp = PDGetTotalTime();
#if BR_ENDIAN_BIG
NetSwapMessageAndContents(pMessage);
#endif
GetCheckSum(pMessage);
return PDNetSendMessageToAddress(pDetails, pMessage, pAddress);
}
Expand All @@ -833,6 +837,9 @@ int NetSendMessageToPlayer(tNet_game_details* pDetails, tNet_message* pMessage,
}
pMessage->sender = gLocal_net_ID;
pMessage->senders_time_stamp = PDGetTotalTime();
#if BR_ENDIAN_BIG
NetSwapMessageAndContents(pMessage);
#endif
for (i = 0; i < gNumber_of_net_players; i++) {
if (gNet_players[i].ID == pPlayer) {
GetCheckSum(pMessage);
Expand All @@ -851,6 +858,9 @@ int NetSendMessageToHost(tNet_game_details* pDetails, tNet_message* pMessage) {
}
pMessage->sender = gLocal_net_ID;
pMessage->senders_time_stamp = PDGetTotalTime();
#if BR_ENDIAN_BIG
NetSwapMessageAndContents(pMessage);
#endif
DoCheckSum(pMessage);
return PDNetSendMessageToAddress(pDetails, pMessage, &pDetails->pd_net_info);
}
Expand All @@ -867,6 +877,9 @@ int NetSendMessageToAllPlayers(tNet_game_details* pDetails, tNet_message* pMessa

pMessage->sender = gLocal_net_ID;
pMessage->senders_time_stamp = PDGetTotalTime();
#if BR_ENDIAN_BIG
NetSwapMessageAndContents(pMessage);
#endif
GetCheckSum(pMessage);
return PDNetSendMessageToAllPlayers(pDetails, pMessage);
}
Expand Down Expand Up @@ -1802,6 +1815,11 @@ void ReceivedMessage(tNet_message* pMessage, void* pSender_address, tU32 pReceiv

for (i = 0; i < pMessage->num_contents; i++) {
if (contents->header.type <= NETMSGID_CARDETAILS || PlayerIsInList(pMessage->sender)) {
#if BR_ENDIAN_BIG
if (pMessage->sender != gLocal_net_ID) {
NetSwapContents(contents);
}
#endif
switch (contents->header.type) {
case NETMSGID_SENDMEDETAILS: // 0x00,
ReceivedSendMeDetails(contents, pSender_address);
Expand Down Expand Up @@ -1918,6 +1936,9 @@ void NetReceiveAndProcessMessages(void) {
gIn_net_service = 1;
while ((message = NetGetNextMessage(gCurrent_net_game, &sender_address)) != NULL) {
receive_time = GetRaceTime();
#if BR_ENDIAN_BIG
NetSwapMessage(message);
#endif
if (message->magic_number == 0x763a5058) {
CheckCheckSum(message);
ReceivedMessage(message, sender_address, receive_time);
Expand Down Expand Up @@ -2145,6 +2166,9 @@ int NetGuaranteedSendMessageToAddress(tNet_game_details* pDetails, tNet_message*
gGuarantee_list[gNext_guarantee].NotifyFail = pNotifyFail;
gGuarantee_list[gNext_guarantee].recieved = 0;
gNext_guarantee++;
#if BR_ENDIAN_BIG
NetSwapMessageAndContents(pMessage);
#endif
DoCheckSum(pMessage);
return PDNetSendMessageToAddress(pDetails, pMessage, pAddress);
}
Expand Down
Loading
Loading