loadsave.c - cap number of vehicles saved#479
Open
yukichigai wants to merge 8 commits into
Open
Conversation
Add a limit of 48 vehicles to save stolen status for, as writing more than this will corrupt the save file and cause errors when it is loaded.
madebr
requested changes
Sep 23, 2025
madebr
left a comment
madebr
left a comment
Collaborator
There was a problem hiding this comment.
Forks with incompatible savegames should modify CalcLSChecksum to create guaranteed incompatible savegames.
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Author
|
Updated with @madebr 's recommended changes, which make the fix only apply when DETHRACE_FIX_BUGS is defined during compile. |
Owner
|
@madebr are you ok with the latest version of this PR? |
madebr
approved these changes
Oct 17, 2025
Collaborator
There was a problem hiding this comment.
To avoid incompatibility with dethrace and/or the original games, please modify CalcLSChecksum to make it incompatible (in your forks).
This can be done easily by changing the initial value of checksum to another non-zero value:
dethrace/src/DETHRACE/common/loadsave.c
Line 109 in d5bdca5
Not sure this is actually needed..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a limit of 48 vehicles to save stolen status, as writing more than this will corrupt the save file and cause errors when it is loaded.