Skip to content

Fix macOS dynamic SDL app bundling#1135

Open
jeff-1amstudios wants to merge 3 commits into
dethrace-labs:mainfrom
jeff-1amstudios:codex/macos-dynamic-sdl-bundle
Open

Fix macOS dynamic SDL app bundling#1135
jeff-1amstudios wants to merge 3 commits into
dethrace-labs:mainfrom
jeff-1amstudios:codex/macos-dynamic-sdl-bundle

Conversation

@jeff-1amstudios

@jeff-1amstudios jeff-1amstudios commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • fix macOS dynamic SDL library discovery for app bundles
  • bundle SDL2/SDL3 dylibs into the installed app and fix the bundle fixup/signing path
  • use SDL pixel-art scaling for the SDL3 screen texture and add the libSDL3.dylib alias expected by the loader

SDL3 uses liner scaling by default so it was all blurry

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

reccmp report


Saved diff report generated June 30 2026, 16:36:22 (16:11:27 ago)


Total effective accuracy 96.45% across 2387 functions (96.08% actual accuracy)
13 functions are aligned (0.54%)

@madebr

madebr commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Is this dmg file layout ok for macOS?

├── bin
│   └── Deth Race.app
│       └── Contents
│           ├── _CodeSignature
│           │   └── CodeResources
│           ├── Info.plist
│           ├── MacOS
│           │   ├── Deth Race
│           │   ├── libSDL2-2.0.0.dylib
│           │   ├── libSDL3.0.dylib
│           │   └── libSDL3.dylib -> libSDL3.0.dylib
│           └── Resources
│               └── dethrace.icns
└── share
    └── doc
        └── dethrace
            └── LICENSE

The bin and share/doc/dethrace should not be there.
The license file should be in the bundle.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

reccmp report


Saved diff report generated June 30 2026, 16:36:22 (1 day, 2:33:18 ago)


Total effective accuracy 96.45% across 2387 functions (96.08% actual accuracy)
13 functions are aligned (0.54%)

@madebr

madebr commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Is LICENSE placed correctly? Should it be in or outside the app bundle?

├── Deth Race.app
│   └── Contents
│       ├── _CodeSignature
│       │   └── CodeResources
│       ├── Info.plist
│       ├── MacOS
│       │   ├── Deth Race
│       │   ├── libSDL2-2.0.0.dylib
│       │   ├── libSDL3.0.dylib
│       │   └── libSDL3.dylib -> libSDL3.0.dylib
│       └── Resources
│           └── dethrace.icns
└── LICENSE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants